IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date:   Wed Sep 18 16:55:49 2019

    Change the way to detect mismatch between POJO and query
   
    This fixes cursor mismatch warnings with expandProjection.
   
    Bug: 140759491
    Test: QueryMethodProcessorTest
    Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
  Created: 2019-10-14 17:23:42.610596+00:00
  Changes: aosp/1123258
 

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date:   Thu Apr 16 16:47:05 2020

    Re-factor how errors are dismissed when query is re-written
   
    This CL changes how we handle errors/warnings if query is
    re-written.
    There was a bug in expandProjection where we would report warnings
    for things that Room already fixes automatically (b/140759491).
    The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
    solved it by deferring validating of columns until after re-write
    decision is made. Unfortunately, this required changing PojoRowAdapter
    to have a dummy mapping until it is validating, make it hard to use
    as it does have a non-null mapping which is not useful.
   
    This CL partially reverts that change and instead rely on the log
    deferring logic we have in Context. This way, we don't need to break
    the stability of PojoRowAdapter while still having the ability to
    drop warnings that room fixes. This will also play nicer when we
    have different query re-writing options that can use more information
    about the query results.
   
    Bug: 153387066
    Bug: 140759491
    Test: existing tests pass
    Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M       room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

This has been fixed internally and will be available in alpha03.

As per the Principles of Navigation (https://developer.android.com/topic/libraries/architecture/navigation/navigation-principles), you should structure your navigation graph and your app around having a fixed start destination that serves as a signpost for users that the next time they hit the system back button, they'll go back to the launcher. This, in many cases, precludes the need to remove the initial start destination from the back stack.

The Implement Conditional Navigation page (https://developer.android.com/topic/libraries/architecture/navigation/navigation-conditional) explains the suggested approach where navigation destinations such as onboarding, login, etc. are something that should be launched only as needed from the fixed start destination / elsewhere in your graph rather than be used as the start destination of your graph entirely. We're working on fleshing out the Conditional Navigation page with further examples and code on how to approach this common scenario.

Any update on when alpha03 will drop?

@5 Are you suggesting that the start Fragment would just check which Fragment to navigate to right away, such as login/permissions/onboarding,  vs the rest?
This Fragment won't have any UI ..

Why this weird solution, instead of just setting a new root to the graph and switch to it?
If at some point, for example, a core permission was found not to be granted, we could set to switch to the permissions Fragment and make it the new root.
Or, if the user has chosen to logout, we could set to switch to the login Fragment and make it the new root.

What you suggest is to just pop all to the same Fragment, and let it choose instead?

Any news or updates? I change the startDestination and want to remove the first-started fragment, before go next. I can't do it. setPopUpTo doesn't work, popBackStack just closes the activity. From time to time I check the jetpack navigation - it becomes better, but it's still to raw. Old school navigation or Cicerone work simpler and better