Fixed
Status Update
No update yet.
Comments
il...@google.com
je...@gmail.com
since these are in public API (:/) we need to do this in 1.2
il...@google.com
il...@google.com
since it is already marked as deprecated, we can probably do it by now.
so...@gmail.com
Opening diff shortly
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
[Deleted User] <[Deleted User]>
It was fixed in alpha03, but came back in alpha04. I'm having same issue with a graph like this:
<fragment
android:id="@+id/destination_fragmentA"
android:name="com.test.FragmentA"
android:label="FragmentA">
<action
android:id="@id/to_fragment_b"
app:destination="@id/destination_fragmentB"
/>
<action
android:id="@id/to_fragment_c"
app:destination="@id/destination_fragmentC"
/>
</fragment>
<fragment
android:id="@+id/destination_fragmentB"
android:name="com.test.FragmentB"
android:label="FragmentB">
<action
android:id="@id/to_fragment_c"
app:destination="@id/destination_fragmentC"
app:popUpTo="@id/destination_fragmentA"
/>
</fragment>
<fragment
android:id="@+id/destination_fragmentC"
android:name="com.test.FragmentC"
android:label="FragmentC">
</fragment>
1. FragmentA opens FragmentB
2. FragmentB opens FragmentC and removes itself from stack with app:popUpTo="@id/destination_fragmentA"
3. Go back to FragmentA from FragmentC with back button
4. Open FragmentC -> crash java.lang.IllegalArgumentException: navigation destination com.test:id/to_fragment_c is unknown to this NavController
Scenario is similar to one described inhttps://issuetracker.google.com/issues/110179436 , but without subgraph.
<fragment
android:id="@+id/destination_fragmentA"
android:name="com.test.FragmentA"
android:label="FragmentA">
<action
android:id="@id/to_fragment_b"
app:destination="@id/destination_fragmentB"
/>
<action
android:id="@id/to_fragment_c"
app:destination="@id/destination_fragmentC"
/>
</fragment>
<fragment
android:id="@+id/destination_fragmentB"
android:name="com.test.FragmentB"
android:label="FragmentB">
<action
android:id="@id/to_fragment_c"
app:destination="@id/destination_fragmentC"
app:popUpTo="@id/destination_fragmentA"
/>
</fragment>
<fragment
android:id="@+id/destination_fragmentC"
android:name="com.test.FragmentC"
android:label="FragmentC">
</fragment>
1. FragmentA opens FragmentB
2. FragmentB opens FragmentC and removes itself from stack with app:popUpTo="@id/destination_fragmentA"
3. Go back to FragmentA from FragmentC with back button
4. Open FragmentC -> crash java.lang.IllegalArgumentException: navigation destination com.test:id/to_fragment_c is unknown to this NavController
Scenario is similar to one described in
an...@gmail.com
I'm getting this, or a similar, issue re-occurring in android.arch.navigation:navigation-fragment-ktx:1.0.0-alpha06. I've recorded a screen capture and updated the linked application.
an...@gmail.com
In another application I have it where navigating to a fragment through a global action makes it so that the NavigationDrawer no longer pops down when clicking the toolbar icon. As noted in the screen recording I had to click the "Import" menu item twice to get it to work on the third time through (prior to the crash).
Description
E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.jetpacknavigationtest, PID: 20199
java.util.NoSuchElementException
at java.util.ArrayDeque.removeLast(ArrayDeque.java:274)
at androidx.navigation.fragment.FragmentNavigator.popBackStack(FragmentNavigator.java:87)
at androidx.navigation.NavController.popBackStack(NavController.java:280)
at androidx.navigation.NavController.navigate(NavController.java:642)
at androidx.navigation.NavController.navigate(NavController.java:592)
at androidx.navigation.Navigation$1.onClick(Navigation.java:118)
at android.view.View.performClick(View.java:6294)
at android.view.View$PerformClick.run(View.java:24770)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
Component used:
android.arch.navigation:navigation-fragment-ktx
Version used:
1.0.0-alpha02
Devices/Android versions reproduced on:
Android_Accelerated_x86_Oreo.avd
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).