RoomOpenHelper's secondary constructor breaks contract [110197391]

Fixed

Bug

NeedsInfo

Status Update

No update yet.

Description

yb...@google.com

created issue #1

Jun 14, 2018 01:59PM

RoomOpenHelper's 2nd constructor passes null for identityHash which is marked as non-null.

we should just pass the same identity.

This is only a backwards compatibility issue and will crash for Room instances that were compiled w/ the old room version.

Comments

yb...@google.com <yb...@google.com> #2Jun 15, 2018 02:54AM

since these are in public API (:/) we need to do this in 1.2

yb...@google.com <yb...@google.com> Jun 15, 2018 05:11PM

Marked as fixed.

va...@gmail.com <va...@gmail.com> #3Jun 20, 2018 09:00AM

since it is already marked as deprecated, we can probably do it by now.

da...@gmail.com <da...@gmail.com> #4Nov 8, 2023 07:52AM

Opening diff shortly

Issue 110197391

Description

Issue summary

Comments

yb...@google.com <yb...@google.com> #2Jun 15, 2018 02:54AM

yb...@google.com <yb...@google.com> Jun 15, 2018 05:11PM

va...@gmail.com <va...@gmail.com> #3Jun 20, 2018 09:00AM

da...@gmail.com <da...@gmail.com> #4Nov 8, 2023 07:52AM

Add comment

Issue metadata