Fixed
Status Update
Comments
il...@google.com <il...@google.com>
il...@google.com <il...@google.com> #2
Converting placeholders into arguments is the documented behavior: https://developer.android.com/reference/androidx/navigation/NavDestination.html#addDeepLink(java.lang.String)
What's missing is that NavDestination doesn't have any API for reading in types or applying that to deep links. We should move that logic from NavInflater to NavDestination so that both XML inflated NavDestinations and programmatically constructed NavDestinations have access to that type information.
What's missing is that NavDestination doesn't have any API for reading in types or applying that to deep links. We should move that logic from NavInflater to NavDestination so that both XML inflated NavDestinations and programmatically constructed NavDestinations have access to that type information.
wk...@google.com <wk...@google.com>
wk...@google.com <wk...@google.com>
be...@google.com <be...@google.com> #3
no impact to nav editor, right?
il...@google.com <il...@google.com> #4
No impact on the nav editor, but we should try to fix this before beta since this will impact developers parsing the arguments from deep links (ideally, they can use the same Args class).
il...@google.com <il...@google.com> #5
This has been fixed in https://android-review.googlesource.com/835484 and will be available in Navigation 1.0.0-alpha09
Description
It would be great to have a well-defined, documented and supported way of passing data from a deep link URL to a destination as an argument, with type safety provided by safeargs.