Fixed
Status Update
No update yet.
Comments
fr...@ingenie.com
Hi. Thanks for reporting this. Fixed in alpha-04
il...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
[Deleted User] <[Deleted User]>
deleted
il...@google.com
ap...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d967abdf673a9ab9249fedead4cb0389139e7e70
Author: jbwoods <jbwoods@google.com>
Date: Thu Apr 18 15:36:48 2019
Add hasDeepLink Api to NavDestination
When users attempt to navigate to a deep link destination, if the deep
link is invalid an IllegalArgumentException is thrown. This Api offers
a way to verify the deeplink is valid before attempting to navigate, and
gives developers more flexibility to handle the case where the deep link
may be invalid.
It uses matchDeepLink() and returns whether a match was found.
Test: New tests and ./gradlew checkApi
BUG: 117437718, 110412864
Change-Id: Iabbca9cfbb864ce305d84d9e4f616d2b43dc7ac6
M navigation/common/api/2.1.0-alpha03.txt
M navigation/common/api/current.txt
M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDestination.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
https://android-review.googlesource.com/948136
https://goto.google.com/android-sha1/d967abdf673a9ab9249fedead4cb0389139e7e70
Branch: androidx-master-dev
commit d967abdf673a9ab9249fedead4cb0389139e7e70
Author: jbwoods <jbwoods@google.com>
Date: Thu Apr 18 15:36:48 2019
Add hasDeepLink Api to NavDestination
When users attempt to navigate to a deep link destination, if the deep
link is invalid an IllegalArgumentException is thrown. This Api offers
a way to verify the deeplink is valid before attempting to navigate, and
gives developers more flexibility to handle the case where the deep link
may be invalid.
It uses matchDeepLink() and returns whether a match was found.
Test: New tests and ./gradlew checkApi
BUG: 117437718, 110412864
Change-Id: Iabbca9cfbb864ce305d84d9e4f616d2b43dc7ac6
M navigation/common/api/2.1.0-alpha03.txt
M navigation/common/api/current.txt
M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDestination.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
il...@google.com
This has been implemented internally and will be available in Navigation 2.1.0-alpha03.
Now in addition to navigating via an R.id, you can reuse the same <deepLink> elements in your graph to navigate(Uri).
Now in addition to navigating via an R.id, you can reuse the same <deepLink> elements in your graph to navigate(Uri).
Description
Version used: 1.0.0-alpha02
Navigating via id works great for flat navigation graphs contained within a single module, but for multi-module cases that have separate graphs (included together by higher level modules), there's no easy way to navigate bidirectionally between them.
It would be nice to be able to navigate via URI, preferably in a way that would allow you to navigate to destinations even within other graphs (which normally you wouldn't be able to navigate directly to).
This would differ from using NavDeepLinkBuilder since it wouldn't blow away the back stack with a synthetic back stack, but just add the new destination to the back stack just like any other navigate() call.