Fixed
Status Update
No update yet.
Comments
fr...@ingenie.com
Project: platform/frameworks/support
Branch: androidx-main
commit d8ae257b1d34561fa4838556c41050b79033a18a
Author: Clara Fok <clarafok@google.com>
Date: Wed Feb 28 12:47:31 2024
DeepLink query params now allow {argName} values for String types
For arguments of NavType<String>, arg values that are in the form of curly braces around argument name is now allowed as valid values. For all other types, this value is still considered as invalid (or absent of argument value).
Internal tests have been updated to reflect this new change. To be precise:
1. NavControllerRouteTest.kt - tests that are setup with absence of value were passing values of {argName} with StringType. Since this is no longer processed as absence of value, StringType has been changed to IntArrayType.
2. NavDeepLinkTest - likewise as NavControllerRouteTest.kt, with additional new test to assert that {argName} is invalid for non-String types.
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 327274038
Relnote: "Query parameters in DeepLink now allows values in the form of curly braces around argument name (i.e. {argName}) as valid values for string-based NavTypes. This contrasts with before where such a value would be considered invalid (or absence of value) for all types."
Change-Id: I183028e2f77d63158a9a567c43da016722397cb8
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
https://android-review.googlesource.com/2982559
Branch: androidx-main
commit d8ae257b1d34561fa4838556c41050b79033a18a
Author: Clara Fok <clarafok@google.com>
Date: Wed Feb 28 12:47:31 2024
DeepLink query params now allow {argName} values for String types
For arguments of NavType<String>, arg values that are in the form of curly braces around argument name is now allowed as valid values. For all other types, this value is still considered as invalid (or absent of argument value).
Internal tests have been updated to reflect this new change. To be precise:
1. NavControllerRouteTest.kt - tests that are setup with absence of value were passing values of {argName} with StringType. Since this is no longer processed as absence of value, StringType has been changed to IntArrayType.
2. NavDeepLinkTest - likewise as NavControllerRouteTest.kt, with additional new test to assert that {argName} is invalid for non-String types.
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 327274038
Relnote: "Query parameters in DeepLink now allows values in the form of curly braces around argument name (i.e. {argName}) as valid values for string-based NavTypes. This contrasts with before where such a value would be considered invalid (or absence of value) for all types."
Change-Id: I183028e2f77d63158a9a567c43da016722397cb8
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
il...@google.com
Fixed internally and available in navigation 2.8.0-alpha05
[Deleted User] <[Deleted User]>
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-alpha05androidx.navigation:navigation-runtime:2.8.0-alpha05
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ffcb91a4f35e0221b0bb3fb4b6b44d1a77bc9f7b
Author: jbwoods <jbwoods@google.com>
Date: Tue Apr 09 13:53:57 2019
Allow navigating in app via deep link URIs
Adds API to call navigate() with a deeplink. It also allows for navigation
to destinations within other graphs (as long as the graphs are included
together by higher level modules). A new destination is added to the back
stack and popping it returns to the previous destination, even if it is
in a different graph.
Test: new tests and ran nav controller tests
./gradlew checkApi
BUG: 110412864
Change-Id: Ie88f3ab8359c6a9fde28f0fc29c1917cc23f41f7
M navigation/runtime/api/2.1.0-alpha03.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
A navigation/runtime/src/androidTest/res/navigation/nav_multiple_navigation.xml
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
https://android-review.googlesource.com/941801
https://goto.google.com/android-sha1/ffcb91a4f35e0221b0bb3fb4b6b44d1a77bc9f7b
Branch: androidx-master-dev
commit ffcb91a4f35e0221b0bb3fb4b6b44d1a77bc9f7b
Author: jbwoods <jbwoods@google.com>
Date: Tue Apr 09 13:53:57 2019
Allow navigating in app via deep link URIs
Adds API to call navigate() with a deeplink. It also allows for navigation
to destinations within other graphs (as long as the graphs are included
together by higher level modules). A new destination is added to the back
stack and popping it returns to the previous destination, even if it is
in a different graph.
Test: new tests and ran nav controller tests
./gradlew checkApi
BUG: 110412864
Change-Id: Ie88f3ab8359c6a9fde28f0fc29c1917cc23f41f7
M navigation/runtime/api/2.1.0-alpha03.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
A navigation/runtime/src/androidTest/res/navigation/nav_multiple_navigation.xml
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d967abdf673a9ab9249fedead4cb0389139e7e70
Author: jbwoods <jbwoods@google.com>
Date: Thu Apr 18 15:36:48 2019
Add hasDeepLink Api to NavDestination
When users attempt to navigate to a deep link destination, if the deep
link is invalid an IllegalArgumentException is thrown. This Api offers
a way to verify the deeplink is valid before attempting to navigate, and
gives developers more flexibility to handle the case where the deep link
may be invalid.
It uses matchDeepLink() and returns whether a match was found.
Test: New tests and ./gradlew checkApi
BUG: 117437718, 110412864
Change-Id: Iabbca9cfbb864ce305d84d9e4f616d2b43dc7ac6
M navigation/common/api/2.1.0-alpha03.txt
M navigation/common/api/current.txt
M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDestination.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
https://android-review.googlesource.com/948136
https://goto.google.com/android-sha1/d967abdf673a9ab9249fedead4cb0389139e7e70
Branch: androidx-master-dev
commit d967abdf673a9ab9249fedead4cb0389139e7e70
Author: jbwoods <jbwoods@google.com>
Date: Thu Apr 18 15:36:48 2019
Add hasDeepLink Api to NavDestination
When users attempt to navigate to a deep link destination, if the deep
link is invalid an IllegalArgumentException is thrown. This Api offers
a way to verify the deeplink is valid before attempting to navigate, and
gives developers more flexibility to handle the case where the deep link
may be invalid.
It uses matchDeepLink() and returns whether a match was found.
Test: New tests and ./gradlew checkApi
BUG: 117437718, 110412864
Change-Id: Iabbca9cfbb864ce305d84d9e4f616d2b43dc7ac6
M navigation/common/api/2.1.0-alpha03.txt
M navigation/common/api/current.txt
M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDestination.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
il...@google.com
This has been implemented internally and will be available in Navigation 2.1.0-alpha03.
Now in addition to navigating via an R.id, you can reuse the same <deepLink> elements in your graph to navigate(Uri).
Now in addition to navigating via an R.id, you can reuse the same <deepLink> elements in your graph to navigate(Uri).
Description
Version used: 1.0.0-alpha02
Navigating via id works great for flat navigation graphs contained within a single module, but for multi-module cases that have separate graphs (included together by higher level modules), there's no easy way to navigate bidirectionally between them.
It would be nice to be able to navigate via URI, preferably in a way that would allow you to navigate to destinations even within other graphs (which normally you wouldn't be able to navigate directly to).
This would differ from using NavDeepLinkBuilder since it wouldn't blow away the back stack with a synthetic back stack, but just add the new destination to the back stack just like any other navigate() call.