Fixed
Status Update
No update yet.
Comments
fr...@ingenie.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
il...@google.com
[Deleted User] <[Deleted User]>
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ffcb91a4f35e0221b0bb3fb4b6b44d1a77bc9f7b
Author: jbwoods <jbwoods@google.com>
Date: Tue Apr 09 13:53:57 2019
Allow navigating in app via deep link URIs
Adds API to call navigate() with a deeplink. It also allows for navigation
to destinations within other graphs (as long as the graphs are included
together by higher level modules). A new destination is added to the back
stack and popping it returns to the previous destination, even if it is
in a different graph.
Test: new tests and ran nav controller tests
./gradlew checkApi
BUG: 110412864
Change-Id: Ie88f3ab8359c6a9fde28f0fc29c1917cc23f41f7
M navigation/runtime/api/2.1.0-alpha03.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
A navigation/runtime/src/androidTest/res/navigation/nav_multiple_navigation.xml
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
https://android-review.googlesource.com/941801
https://goto.google.com/android-sha1/ffcb91a4f35e0221b0bb3fb4b6b44d1a77bc9f7b
Branch: androidx-master-dev
commit ffcb91a4f35e0221b0bb3fb4b6b44d1a77bc9f7b
Author: jbwoods <jbwoods@google.com>
Date: Tue Apr 09 13:53:57 2019
Allow navigating in app via deep link URIs
Adds API to call navigate() with a deeplink. It also allows for navigation
to destinations within other graphs (as long as the graphs are included
together by higher level modules). A new destination is added to the back
stack and popping it returns to the previous destination, even if it is
in a different graph.
Test: new tests and ran nav controller tests
./gradlew checkApi
BUG: 110412864
Change-Id: Ie88f3ab8359c6a9fde28f0fc29c1917cc23f41f7
M navigation/runtime/api/2.1.0-alpha03.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
A navigation/runtime/src/androidTest/res/navigation/nav_multiple_navigation.xml
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d967abdf673a9ab9249fedead4cb0389139e7e70
Author: jbwoods <jbwoods@google.com>
Date: Thu Apr 18 15:36:48 2019
Add hasDeepLink Api to NavDestination
When users attempt to navigate to a deep link destination, if the deep
link is invalid an IllegalArgumentException is thrown. This Api offers
a way to verify the deeplink is valid before attempting to navigate, and
gives developers more flexibility to handle the case where the deep link
may be invalid.
It uses matchDeepLink() and returns whether a match was found.
Test: New tests and ./gradlew checkApi
BUG: 117437718, 110412864
Change-Id: Iabbca9cfbb864ce305d84d9e4f616d2b43dc7ac6
M navigation/common/api/2.1.0-alpha03.txt
M navigation/common/api/current.txt
M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDestination.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
https://android-review.googlesource.com/948136
https://goto.google.com/android-sha1/d967abdf673a9ab9249fedead4cb0389139e7e70
Branch: androidx-master-dev
commit d967abdf673a9ab9249fedead4cb0389139e7e70
Author: jbwoods <jbwoods@google.com>
Date: Thu Apr 18 15:36:48 2019
Add hasDeepLink Api to NavDestination
When users attempt to navigate to a deep link destination, if the deep
link is invalid an IllegalArgumentException is thrown. This Api offers
a way to verify the deeplink is valid before attempting to navigate, and
gives developers more flexibility to handle the case where the deep link
may be invalid.
It uses matchDeepLink() and returns whether a match was found.
Test: New tests and ./gradlew checkApi
BUG: 117437718, 110412864
Change-Id: Iabbca9cfbb864ce305d84d9e4f616d2b43dc7ac6
M navigation/common/api/2.1.0-alpha03.txt
M navigation/common/api/current.txt
M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDestination.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
il...@google.com
This has been implemented internally and will be available in Navigation 2.1.0-alpha03.
Now in addition to navigating via an R.id, you can reuse the same <deepLink> elements in your graph to navigate(Uri).
Now in addition to navigating via an R.id, you can reuse the same <deepLink> elements in your graph to navigate(Uri).
Description
Version used: 1.0.0-alpha02
Navigating via id works great for flat navigation graphs contained within a single module, but for multi-module cases that have separate graphs (included together by higher level modules), there's no easy way to navigate bidirectionally between them.
It would be nice to be able to navigate via URI, preferably in a way that would allow you to navigate to destinations even within other graphs (which normally you wouldn't be able to navigate directly to).
This would differ from using NavDeepLinkBuilder since it wouldn't blow away the back stack with a synthetic back stack, but just add the new destination to the back stack just like any other navigate() call.