Verified
Status Update
No update yet.
Comments
yb...@google.com
cc...@google.com
cc...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 0d76cb8cdde123c08a05390a01a6a3d9d599c270
Author: Mihai Popa <popam@google.com>
Date: Tue Feb 22 13:56:58 2022
Add LazyHorizontalGrid
Relnote: "LazyHorizontalGrid was added."
Fixes: 191238807
Test: new tests in lazy.grid
Change-Id: I61ae7abe269fdb3776c301dd5c233762f9766f4d
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridAnimateItemPlacementTest.kt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyGrid.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridItemPlacementAnimator.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/LazyGridSamples.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredItem.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGrid.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyArrangementsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredLine.kt
https://android-review.googlesource.com/1994930
Branch: androidx-main
commit 0d76cb8cdde123c08a05390a01a6a3d9d599c270
Author: Mihai Popa <popam@google.com>
Date: Tue Feb 22 13:56:58 2022
Add LazyHorizontalGrid
Relnote: "LazyHorizontalGrid was added."
Fixes: 191238807
Test: new tests in lazy.grid
Change-Id: I61ae7abe269fdb3776c301dd5c233762f9766f4d
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridAnimateItemPlacementTest.kt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyGrid.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridItemPlacementAnimator.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/LazyGridSamples.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredItem.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGrid.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyArrangementsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredLine.kt
ma...@gmail.com
ae...@gmail.com
...
[Deleted User] <[Deleted User]>
Eas
[Deleted User] <[Deleted User]>
Epic game
ma...@gmail.com
GameOver
Description
Version used: 1.0.0
Devices/Android versions reproduced on: Moto E4/7.1.1
This is a pretty simple bug. In PagedStoragedDiffHelper / OffsettingListUpdateCallback onMoved is incorrectly implemented
@Override
public void onMoved(int fromPosition, int toPosition) {
mCallback.onRemoved(fromPosition + mOffset, toPosition + mOffset);
}
This is a huge issue in large lists. In my case i have a paged list of 30000 items. If i move item in position 15000 to item in position 15001, mCallback.onRemoved is called with parameters of 15000 and 15001. The second param (15001) is number of items removed.. so basically my adapter now things items 15000-30000 have been removed from the list which is clearly not the case