OffsettingListUpdateCallback.onMoved calls mCallback.onRemoved instead of mCallback.onMoved [110711937]

Verified

Bug

Status Update

No update yet.

Description

go...@gmail.com

created issue #1

Jun 24, 2018 04:57PM

Component used: Paging Library
Version used: 1.0.0
Devices/Android versions reproduced on: Moto E4/7.1.1

This is a pretty simple bug. In PagedStoragedDiffHelper / OffsettingListUpdateCallback onMoved is incorrectly implemented

@Override
public void onMoved(int fromPosition, int toPosition) {
mCallback.onRemoved(fromPosition + mOffset, toPosition + mOffset);
}

This is a huge issue in large lists. In my case i have a paged list of 30000 items. If i move item in position 15000 to item in position 15001, mCallback.onRemoved is called with parameters of 15000 and 15001. The second param (15001) is number of items removed.. so basically my adapter now things items 15000-30000 have been removed from the list which is clearly not the case

Comments

yb...@google.com <yb...@google.com> Jun 24, 2018 06:59PM

Assigned to cc...@google.com.

cc...@google.com <cc...@google.com> Jun 25, 2018 04:41PM

Accepted by cc...@google.com.

cc...@google.com <cc...@google.com> #2Jun 25, 2018 09:10PM

Marked as fixed.

since these are in public API (:/) we need to do this in 1.2

cc...@google.com <cc...@google.com> #3Jun 26, 2018 05:57PM

Verified by cc...@google.com.

since it is already marked as deprecated, we can probably do it by now.

ma...@gmail.com <ma...@gmail.com> #4Aug 19, 2018 03:56PM

Opening diff shortly

ae...@gmail.com <ae...@gmail.com> #5Jan 26, 2019 07:14PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

[Deleted User] <[Deleted User]> #6Apr 30, 2019 05:35PM

Eas

[Deleted User] <[Deleted User]> #7Sep 10, 2020 04:28AM

Epic game

ma...@gmail.com <ma...@gmail.com> #8Mar 4, 2022 01:38AM

GameOver

sa...@gmail.com <sa...@gmail.com> #9Dec 3, 2022 11:32AM

https://drive.google.com/file/d/13-I4nbq_zYhIKNfY7Rgl7Tj27KNyF-Ae/view?usp=drive_web (My Android Help & Feedback)