Fixed
Status Update
No update yet.
Comments
il...@google.com
since these are in public API (:/) we need to do this in 1.2
ju...@gmail.com
since it is already marked as deprecated, we can probably do it by now.
il...@google.com
Opening diff shortly
ju...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
il...@google.com
il...@google.com
A NavigationUI.setupWithNavController method for CollapsingToolbarLayout has been added and will be available in alpha03.
Description
Version used: 1.0.0-alpha02
Devices/Android versions reproduced on: all devices (e.g. Pixel 2, Android 8.1.0, API27)
I'm not quite sure this is a bug but I'm having trouble using Navigation UI component with both standard Toolbar and CollapsingToolbarLayout. Is there a plan to include some kind of support for this?
Because switching between items in the bottom navigation that I have and having some of the screens using standard toolbar and some of them CollapsingToolbarLayout it is really difficult to combine.
I went for a solution of having a standard Toolbar in the Activity and CollapsingToolbarLayout in the fragment and when I display this fragment, I hide the toolbar in the Activity. This however creates ugly flickering and moving of the content, which looks bad and also it happens so that Bottom navigation bar gets pushed down too much until I invalidate it.