Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
This was fixed in NavHost
now takes a modifier
parameter directly, avoiding the requirement to wrap the NavHost
in a Box
.
This will be available in Navigation Compose 1.0.0-alpha10.
be...@google.com <be...@google.com> #3
Great news, thank you very much.
il...@google.com <il...@google.com>
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit cdf0e8224cd44a1e444e3d60f93c0d2942bc0aaf
Author: Ian Lake <ilake@google.com>
Date: Thu Mar 21 17:07:47 2019
Allow <activity> destinations to set an explicit package
When navigating via an action, it is sometimes useful
to be able to limit the components to a specific
package such as when using dynamic features or are
handling web URL links within your own app.
By adding an app:targetPackage attribute, we can
ensure that developers can avoid disambiguation
dialogs in those cases.
For inflating from XML, a special package name
of ${applicationId} is supported which is populated
with your application's package name.
Test: updated tests
Fixes: 110975456
Change-Id: I0f0f95efa1cc7ca5c2f26cf9bc60819cc4478a92
M navigation/runtime/api/2.1.0-alpha02.txt
M navigation/runtime/api/current.txt
M navigation/runtime/ktx/api/2.1.0-alpha02.txt
M navigation/runtime/ktx/api/current.txt
M navigation/runtime/ktx/src/androidTest/java/androidx/navigation/ActivityNavigatorDestinationBuilderTest.kt
M navigation/runtime/ktx/src/main/java/androidx/navigation/ActivityNavigatorDestinationBuilder.kt
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
M navigation/runtime/src/main/res/values/attrs.xml
https://android-review.googlesource.com/932187
https://goto.google.com/android-sha1/cdf0e8224cd44a1e444e3d60f93c0d2942bc0aaf
Branch: androidx-master-dev
commit cdf0e8224cd44a1e444e3d60f93c0d2942bc0aaf
Author: Ian Lake <ilake@google.com>
Date: Thu Mar 21 17:07:47 2019
Allow <activity> destinations to set an explicit package
When navigating via an action, it is sometimes useful
to be able to limit the components to a specific
package such as when using dynamic features or are
handling web URL links within your own app.
By adding an app:targetPackage attribute, we can
ensure that developers can avoid disambiguation
dialogs in those cases.
For inflating from XML, a special package name
of ${applicationId} is supported which is populated
with your application's package name.
Test: updated tests
Fixes: 110975456
Change-Id: I0f0f95efa1cc7ca5c2f26cf9bc60819cc4478a92
M navigation/runtime/api/2.1.0-alpha02.txt
M navigation/runtime/api/current.txt
M navigation/runtime/ktx/api/2.1.0-alpha02.txt
M navigation/runtime/ktx/api/current.txt
M navigation/runtime/ktx/src/androidTest/java/androidx/navigation/ActivityNavigatorDestinationBuilderTest.kt
M navigation/runtime/ktx/src/main/java/androidx/navigation/ActivityNavigatorDestinationBuilder.kt
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
M navigation/runtime/src/main/res/values/attrs.xml
il...@google.com <il...@google.com> #5
This is fixed internally and will be available in Navigation 2.1.0-alpha02
Description
Version used: 1.0.0-alpha02
Devices/Android versions reproduced on: x86 emulator API 27
Navigating between activities via URL will result in a disambiguation dialog within an <activity> tag like this:
```
<activity
android:id="@+id/fooBarActivity"
app:data="
app:action="android.intent.action.VIEW"
android:label="FooBarActivity" />
```
Please add a `app:targetPackage` attribute to the activity tag, so when using URLs the disambiguation dialog can be avoided.