Fixed
Status Update
Comments
il...@google.com <il...@google.com>
il...@google.com <il...@google.com>
il...@google.com <il...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
ta...@gmail.com <ta...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
il...@google.com <il...@google.com> #4
deleted
ta...@gmail.com <ta...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
Description
Version used: 1.0.0-alpha02
Devices/Android versions reproduced on: all
There's always an inherent race condition with any OnClickListener where the callback can come in after the state saved. Navigation shouldn't crash in these cases.
Fatal Exception: java.lang.IllegalStateException
Can not perform this action after onSaveInstanceState
android.support.v4.app.FragmentManagerImpl.checkStateLoss (FragmentManager.java:2080)
android.support.v4.app.FragmentManagerImpl.enqueueAction (FragmentManager.java:2106)
android.support.v4.app.BackStackRecord.commitInternal (BackStackRecord.java:683)
android.support.v4.app.BackStackRecord.commit (BackStackRecord.java:637)
androidx.navigation.fragment.FragmentNavigator.navigate (FragmentNavigator.java:158)
androidx.navigation.fragment.FragmentNavigator.navigate (FragmentNavigator.java:45)
androidx.navigation.NavDestination.navigate (NavDestination.java:345)
androidx.navigation.NavController.navigate (NavController.java:645)
androidx.navigation.ui.NavigationUI.onNavDestinationSelected (NavigationUI.java:84)
androidx.navigation.ui.NavigationUI.access$000 (NavigationUI.java:46)
androidx.navigation.ui.NavigationUI$3.onNavigationItemSelected (NavigationUI.java:216)
android.support.design.widget.BottomNavigationView$1.onMenuItemSelected (BottomNavigationView.java:201)