Crash in onNavigationItemSelected: Can not perform this action after onSaveInstanceState [110987825]

Fixed

Bug

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

Jun 30, 2018 04:17PM

Component used: Navigation
Version used: 1.0.0-alpha02
Devices/Android versions reproduced on: all

There's always an inherent race condition with any OnClickListener where the callback can come in after the state saved. Navigation shouldn't crash in these cases.

Fatal Exception: java.lang.IllegalStateException
Can not perform this action after onSaveInstanceState
android.support.v4.app.FragmentManagerImpl.checkStateLoss (FragmentManager.java:2080)
android.support.v4.app.FragmentManagerImpl.enqueueAction (FragmentManager.java:2106)
android.support.v4.app.BackStackRecord.commitInternal (BackStackRecord.java:683)
android.support.v4.app.BackStackRecord.commit (BackStackRecord.java:637)
androidx.navigation.fragment.FragmentNavigator.navigate (FragmentNavigator.java:158)
androidx.navigation.fragment.FragmentNavigator.navigate (FragmentNavigator.java:45)
androidx.navigation.NavDestination.navigate (NavDestination.java:345)
androidx.navigation.NavController.navigate (NavController.java:645)
androidx.navigation.ui.NavigationUI.onNavDestinationSelected (NavigationUI.java:84)
androidx.navigation.ui.NavigationUI.access$000 (NavigationUI.java:46)
androidx.navigation.ui.NavigationUI$3.onNavigationItemSelected (NavigationUI.java:216)
android.support.design.widget.BottomNavigationView$1.onMenuItemSelected (BottomNavigationView.java:201)

Comments

il...@google.com <il...@google.com> Jun 30, 2018 08:38PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Jul 9, 2018 06:17PM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #2Jul 10, 2018 04:00PM

Marked as fixed.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ta...@gmail.com <ta...@gmail.com> #3Jul 12, 2018 07:33PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

il...@google.com <il...@google.com> #4Jul 12, 2018 07:38PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ta...@gmail.com <ta...@gmail.com> #5Jul 12, 2018 09:11PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

Issue 110987825