Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
il...@google.com
ta...@gmail.com
> We accept pull requests! :)
Is there a public repo somewhere? I don't see any obvious repo for it inhttps://android.googlesource.com , and it doesn't seem to be inside https://android.googlesource.com/platform/frameworks/support .
Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.
Is there a public repo somewhere? I don't see any obvious repo for it in
Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.
il...@google.com
Room supports immutability (it can use arg constructors) but does not directly support AutoValue. It is in the schedule but not high priority :/. Idk much about its internals at this stage so I'm not sure how we would implement it but should be totally doable.
Sorry we don't have the source release yet :/.
Sorry we don't have the source release yet :/.
ta...@gmail.com
"It is in the schedule but not high priority" -- completely understandable.
"Sorry we don't have the source release yet :/." -- ah, OK, I thought perhaps with the pull request comment, that meant that there was a repo somewhere that I had overlooked.
Thanks!
"Sorry we don't have the source release yet :/." -- ah, OK, I thought perhaps with the pull request comment, that meant that there was a repo somewhere that I had overlooked.
Thanks!
Description
Version used: 1.0.0-alpha02
Devices/Android versions reproduced on: all
There's always an inherent race condition with any OnClickListener where the callback can come in after the state saved. Navigation shouldn't crash in these cases.
Fatal Exception: java.lang.IllegalStateException
Can not perform this action after onSaveInstanceState
android.support.v4.app.FragmentManagerImpl.checkStateLoss (FragmentManager.java:2080)
android.support.v4.app.FragmentManagerImpl.enqueueAction (FragmentManager.java:2106)
android.support.v4.app.BackStackRecord.commitInternal (BackStackRecord.java:683)
android.support.v4.app.BackStackRecord.commit (BackStackRecord.java:637)
androidx.navigation.fragment.FragmentNavigator.navigate (FragmentNavigator.java:158)
androidx.navigation.fragment.FragmentNavigator.navigate (FragmentNavigator.java:45)
androidx.navigation.NavDestination.navigate (NavDestination.java:345)
androidx.navigation.NavController.navigate (NavController.java:645)
androidx.navigation.ui.NavigationUI.onNavDestinationSelected (NavigationUI.java:84)
androidx.navigation.ui.NavigationUI.access$000 (NavigationUI.java:46)
androidx.navigation.ui.NavigationUI$3.onNavigationItemSelected (NavigationUI.java:216)
android.support.design.widget.BottomNavigationView$1.onMenuItemSelected (BottomNavigationView.java:201)