Fixed
Status Update
Comments
ra...@google.com <ra...@google.com>
ra...@google.com <ra...@google.com> #2
since these are in public API (:/) we need to do this in 1.2
lb...@gmail.com <lb...@gmail.com> #3
since it is already marked as deprecated, we can probably do it by now.
su...@google.com <su...@google.com> #4
Opening diff shortly
lb...@gmail.com <lb...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
Description
Version used:
implementation "android.arch.work:work-runtime-ktx:1.0.0-alpha04"
implementation "android.arch.work:work-firebase:1.0.0-alpha04"
But also the Java one
Devices/Android versions reproduced on:
Nexus 4 with Android 4.4.4
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
Attached
- A screenrecord or screenshots showing the issue (if UI related).
Attached.
The bug is that on newer Android versions, the schedule works fine, yet here on this Android version, the work never gets called.
In the sample, I've scheduled it to run in 30 seconds:
workManager.enqueue(OneTimeWorkRequest.Builder(SampleJob::class.java).addTag(schedultedTag).setInitialDelay(30, TimeUnit.SECONDS).build())
Steps for reproducing the bug:
1. Just press on "schedule job in 30 sec" button.
2. You can wait 30 seconds or even a lot more time, and it won't be launched. I've set that a toast and log will b shown. Nothing occurs.
If I remove the delay, it works fine :
workManager.enqueue(OneTimeWorkRequest.Builder(SampleJob::class.java).addTag(normalJobTag).build())
Same goes if I remove the Firebase usage:
implementation "android.arch.work:work-firebase:1.0.0-alpha04"