IssueTracker

On first blush, this doesn't appear to be related to my current changes, as this is an error in the recomopser not the composer. However, the fact it requires an inline function seems suspiciously close.

The issue appears to be that, starting in 1.4.3, the composer used in the inlined lambda is the one captured from the parent. This is not the right one when a dialog is being presented as it is the composer for the dialog, not the dialog host.

The only change between 1.4.2 and 1.4.3 is https://android-review.googlesource.com/#/q/Ie93edb78b8427e56b4bef15b872a919b8bac0664

Handing this to Andrei to look at as this was his change.

Note to Andrei: After the aosp/2423347, the cross-inline lambda is capturing the $composer parameter from the caller instead of using the $composer parameter passed in to the lambda it was inlined into. This causes changes to be made to the composer that is not currently being used for composition which confused the recomposer.

This issue affects crossinline lambdas that are inlined into another lambda, as demonstrated by the repro case above, when the composable lambda is executed with a different composer than the function declaring the lambda. A different composer is used when a lambda is invoked in a subcomposition such as a dialog, BoxWithConstraints, and LazyColumn, amoung others.

A crossinline lambda is requred because it is illegal to invoke an non-crossinline lambda in a realized lambda (which is what crossinline allows).

The easiest work-around is to remove inline from the function which avoids the expanding of the lambda in another lambda required for this bug to manifest.