Room compiler can't see the TypeConverter of a List<JavaClass> using kapt [111404868]

Fixed

Bug

Status Update

No update yet.

Description

ah...@gmail.com

created issue #1

Jul 13, 2018 08:58AM

Component used: Room
Version used: 1.1.1
Kotlin version: 1.2.51

Room can't detect the TypeConverter of a List<Model> if that Model itself is written in Java and if I convert this class to Kotlin, it works as expected!

I got this error no matter where I put the TypeConverters annotation!
error: Cannot figure out how to save this field into database. You can consider adding a type converter for it.

A project where this can be reproduced is attached!

RoomTypeConverterBug.zip

1 MB

Download

Comments

yb...@google.com <yb...@google.com> Aug 17, 2018 08:03PM

Assigned to da...@google.com.

ap...@google.com <ap...@google.com> #2Oct 10, 2018 09:24PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit cecefceee86fa83c851bae1aeea709ddd3ef6b25
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Oct 09 15:57:59 2018

Use isAssignableWithoutVariance for output type converter matching.

This fixes a situation where a two-way binding converter was not
matching with a Kotlin entity since Kotlin seems to add variance to
the field type. i.e. val data : List<Foo> ends up being a field of type
List<? extends Foo>.

Bug: 111404868
Test: ./gradlew room:integration-tests:kotlintestapp:cC
Change-Id: I3c7d28b327b6ffa10e3b9f77a4859d7d6647a49b

M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/TestDatabase.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/vo/JavaPojo.java
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/vo/JavaPojoConverter.kt

https://android-review.googlesource.com/783749

https://goto.google.com/android-sha1/cecefceee86fa83c851bae1aeea709ddd3ef6b25

da...@google.com <da...@google.com> Oct 10, 2018 09:34PM

Marked as fixed.

[Deleted User] <[Deleted User]> #3Jan 2, 2019 02:12AM

delete

da...@gmail.com <da...@gmail.com> #4Nov 15, 2019 09:58AM

room:2.2.1
kotlin: 1.3.50

I am still getting this error for:
var formIds: List<Long> = arrayListOf(),

Fails with an error:
Cannot figure out how to save this field into database. You can consider adding a type converter for it.
private java.util.List<java.lang.Long> formIds;

but it works for:
var formIds: MutableList<Long> = arrayListOf(),

da...@gmail.com <da...@gmail.com> #5Nov 15, 2019 10:06AM

sorry, it works for
var formIds: ArrayList<Long> = arrayListOf(),

Issue 111404868