NavDirections should implement equals and hashCode [111450897]

Fixed

Feature Request

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jul 13, 2018 11:23PM

Component used: Safe Args
Version used: 1.0.0-alpha03

NavDirections should implement equals and hashCode so that it can more easily be used with Mockito.verify such as in code like:

onView(withText("cc")).perform(click())
verify(repoFragment.navController).navigate(
RepoFragmentDirections.showUser("cc").matcher()
)

It would look similar to

https://github.com/googlesamples/android-architecture-components/blob/8e77a8b90bec775bfdf9fa2244686f73265cdad2/GithubBrowserSample/app/src/androidTest/java/com/android/example/github/util/NavDirectionsMatcher.kt

Comments

da...@google.com <da...@google.com> #2Jul 17, 2018 11:25PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 42d5037be3a80f5ff840eee1f0a74bfb8f287d66
Author: Ben Weiss <benweiss@google.com>
Date: Thu Dec 10 16:20:02 2020

Add factory functions for DynamicNavHostFragment

Bug: 175222619
Test: updateApi and cAT
RelNote: Add factory functions for DynamicNavHostFragment
Change-Id: Icd51523a8f3cc3f93fffc1796c6a270bc28eaede

M navigation/navigation-dynamic-features-fragment/api/current.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_current.txt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilderTest.kt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragmentTest.kt
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java

https://android-review.googlesource.com/1523818

il...@google.com <il...@google.com> #3Jul 19, 2018 06:24PM

Status: Assigned (reopened)

I couldn't seem to find the create method in my codebase on the latest Navigation release 2.3.5. Has this change been merged into latest release?

https://androidx.tech/artifacts/navigation/navigation-dynamic-features-fragment/2.3.5-source/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt.html

da...@google.com <da...@google.com> Jul 19, 2018 10:43PM

Marked as fixed.

il...@google.com <il...@google.com> #4Jul 23, 2018 08:45PM

This adds new APIs therefore will be available in Navigation 2.4.0-alpha01.

Issue 111450897

Description

Issue summary

Comments

da...@google.com <da...@google.com> #2Jul 17, 2018 11:25PM

il...@google.com <il...@google.com> #3Jul 19, 2018 06:24PM

da...@google.com <da...@google.com> Jul 19, 2018 10:43PM

il...@google.com <il...@google.com> #4Jul 23, 2018 08:45PM

Add comment

Issue metadata