Safe Args fails with IDs like "@+id/navigation.xml" [111602491]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jul 18, 2018 06:30PM

Component used: Navigation Safe Args
Version used: 1.0.0-alpha03
Devices/Android versions reproduced on:

When enabling Safe Args on the project in

https://issuetracker.google.com/issues/111569267, one of the generated classes was invalid due to the navigation XML using android:id="@+id/navigation.xml" - it tried to generate public class Navigation.xmlDirections (which is invalid).

aapt correctly translates "@+id/navigation.xml" into R.id.navigation_xml. Safe Args should do the same.

Comments

il...@google.com <il...@google.com> #2Jul 18, 2018 06:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit ef4bd54e5dec9e9e8e5e510baeabc4ff00ef77cd
Author: Sherry Hu <shuanghu@google.com>
Date: Thu Jun 17 11:53:51 2021

Add AbstractListDetailFragment

Bug: 191276636
Test: Will test in sample application and unit tests.
Relnote: Added new AbstractListDetailFragment
Change-Id: Iac4be7b764ced86cdbff3c696c2cbdf2741eb81c

M navigation/navigation-fragment/api/current.txt
M navigation/navigation-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-fragment/api/restricted_current.txt
M navigation/navigation-fragment/build.gradle
A navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/AbstractListDetailFragment.kt
A navigation/navigation-fragment/src/main/res/layout/abstract_list_detail_fragment.xml
M settings.gradle

https://android-review.googlesource.com/1740053

da...@google.com <da...@google.com> Jul 23, 2018 02:57AM

Marked as fixed.

il...@google.com <il...@google.com> #3Jul 23, 2018 08:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit b151f42998cdae5c2d906e745185aaa9049b6e4b
Author: Sherry Hu <shuanghu@google.com>
Date: Thu Jun 17 20:30:18 2021

Add sample application for two-pane navigation.

Bug: 191276636
Test: run sample application.
Change-Id: I6d746f28ae2f076c86b79de5980b43b84b0ea366

M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/MainFragment.kt
A navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/TwoPaneAdapter.kt
A navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/TwoPaneFragment.kt
M navigation/integration-tests/testapp/src/main/res/layout/bottom_bar_menu.xml
A navigation/integration-tests/testapp/src/main/res/layout/list_pane.xml
A navigation/integration-tests/testapp/src/main/res/layout/list_pane_row_item.xml
A navigation/integration-tests/testapp/src/main/res/layout/two_pane_fragment.xml
M navigation/integration-tests/testapp/src/main/res/menu/menu_bottom_nav.xml
M navigation/integration-tests/testapp/src/main/res/navigation/nav_main.xml
A navigation/integration-tests/testapp/src/main/res/navigation/two_pane_navigation.xml
M navigation/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml

https://android-review.googlesource.com/1740716

Issue 111602491

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Jul 18, 2018 06:32PM

da...@google.com <da...@google.com> Jul 23, 2018 02:57AM

il...@google.com <il...@google.com> #3Jul 23, 2018 08:46PM

Add comment

Issue metadata