Safe Args fails with IDs like "@+id/navigation.xml" [111602491]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jul 18, 2018 06:30PM

Component used: Navigation Safe Args
Version used: 1.0.0-alpha03
Devices/Android versions reproduced on:

When enabling Safe Args on the project in

https://issuetracker.google.com/issues/111569267, one of the generated classes was invalid due to the navigation XML using android:id="@+id/navigation.xml" - it tried to generate public class Navigation.xmlDirections (which is invalid).

aapt correctly translates "@+id/navigation.xml" into R.id.navigation_xml. Safe Args should do the same.

Comments

il...@google.com <il...@google.com> #2Jul 18, 2018 06:32PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

da...@google.com <da...@google.com> Jul 23, 2018 02:57AM

Marked as fixed.

il...@google.com <il...@google.com> #3Jul 23, 2018 08:46PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

Issue 111602491

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Jul 18, 2018 06:32PM

da...@google.com <da...@google.com> Jul 23, 2018 02:57AM

il...@google.com <il...@google.com> #3Jul 23, 2018 08:46PM

Add comment

Issue metadata