Back stack not updated when back button is clicked [111907708]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jul 27, 2018 02:00PM

Component used: Navigation architecture component
Version used: 1.0.0-alpha04
Devices/Android versions reproduced on: (does not depend on device)

Let's say, my back stack is A->B. When I click 'back' button, the last fragment is getting popped (fragment A gets displayed), but this is done by the FragmentManager's transaction handling behavior. Inside NavController back stack does not get updated. Thus, if I then try to navigate via action, I get an exception saying that the action is not found (because the top of back stack is still fragment B).

Comments

pi...@googlemail.com <pi...@googlemail.com> #2Jul 28, 2018 07:19AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

NavBug.zip

1.5 MB

Download

se...@google.com <se...@google.com> Jul 30, 2018 11:14PM

Assigned to il...@google.com.

ap...@google.com <ap...@google.com> #3Aug 2, 2018 09:51PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 791a3ffbae3efc6c0cfaa568b9d303eef0a523e0
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Aug 02 09:27:01 2018

Fix back stack inconsistency when detecting back pressed.

FragmentNavigator's back stack was becoming inconsistent with the
FragmentManager's back stack due to in-between multiple pending
operations callbacks occurring that would cause the difference between
the new count and the final count to be equal and thus causing the
amount of pending operations not to be decreased.

This changes takes a slightly different strategy, instead of counting
pending operations, we just flag that we have pending operations and we
don't consider them done until the FragmentManager's back stack is equal
to the Navigator's back stack. Consuming back stack callbacks as long
as there are pending operations so that we don't accidentally detect a
back press. Since a back press causes a popBackStackImmediate() we have
confidence pending operations will be executed causing the Navigator to
reset the flag to later then detect the back press pop.

Bug: 111884848
Bug: 111907708
Test: FragmentNavigatorTest, additionally, manually verified fix works
on both sample projects provided.

Change-Id: I51be4d6a974ecbeeaa1f63d764edabb230ae85e2

M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.java
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/725219

https://goto.google.com/android-sha1/791a3ffbae3efc6c0cfaa568b9d303eef0a523e0

da...@google.com <da...@google.com> Aug 2, 2018 09:52PM

Marked as fixed, reassigned to da...@google.com.

da...@google.com <da...@google.com> #4Aug 3, 2018 05:25PM

A fix for this issue will be available in alpha05.

ar...@gmail.com <ar...@gmail.com> #5Sep 20, 2018 02:46PM

Bug still exist on alpha05.

il...@google.com <il...@google.com> #6Sep 20, 2018 06:22PM

Re #5 - if you're still running into an issue, please file a new issue with a sample project that reproduces your issue.

am...@gmail.com <am...@gmail.com> #7Feb 6, 2019 02:07PM

Bug still exist on alpha11.

il...@google.com <il...@google.com> #8Feb 6, 2019 05:51PM

Re #7 - if you're still running into an issue, please file a new issue with a sample project that reproduces your issue.

me...@gmail.com <me...@gmail.com> #9Sep 20, 2020 05:51PM

this bug is still present in 2.3.0

il...@google.com <il...@google.com> #10Sep 21, 2020 03:35PM

Re #9 - if you're still running into an issue, please file a new issue with a sample project that reproduces your issue. Same as with comment#5 and comment#7