Change theme
Help
Press space for more information.
Show links for this issue (Shortcut: i, l)
Copy issue ID
Previous Issue (Shortcut: k)
Next Issue (Shortcut: j)
Sign in to use full features.
Vote: I am impacted
Notification menu
Refresh (Shortcut: Shift+r)
Go home (Shortcut: u)
Pending code changes (auto-populated)
View issue level access limits(Press Alt + Right arrow for more information)
Unintended behavior
View staffing
Description
Steps to repro:
1. Run adb shell from platform-tools_r24.0.4 (October 14, 2016) and 'ls' a directory with a UTF-8 filename. It looks correct. Version info:
Android Debug Bridge version 1.0.36
Revision 19394af606f6-android
2. Run adb shell from platform-tools_r25 (October 19, 2016) and 'ls' a directory with a UTF-8 filename. It does not look correct. Version info:
Android Debug Bridge version 1.0.36
Revision 84e3321d5db3-android
I investigated and I think the problem is that adb/client/bugreport.cpp includes sysdeps.h too late, so when bugreport.cpp includes commandline.h (which calls fwrite), it doesn't use sysdeps.h's #define fwrite adb_write.
Moving #include "sysdeps.h" earlier in bugreport.cpp fixes the issue. I should have a code review soon.