Fixed
Status Update
Comments
il...@google.com <il...@google.com>
as...@gmail.com <as...@gmail.com> #3
,
ju...@gmail.com <ju...@gmail.com> #4
Yes
[Deleted User] <[Deleted User]> #5
externalCacheFile.delete()
[Deleted User] <[Deleted User]> #6
#1
ro...@gmail.com <ro...@gmail.com> #7
Hi
re...@gmail.com <re...@gmail.com> #9
Drive way
je...@gmail.com <je...@gmail.com> #10
Hoka
hd...@gmail.com <hd...@gmail.com> #11 Restricted
Restricted
Comment has been deleted.
ba...@gmail.com <ba...@gmail.com> #12
Comment has been deleted.
la...@gmail.com <la...@gmail.com> #14
Hi
sh...@gmail.com <sh...@gmail.com> #15
Fortnit
ap...@google.com <ap...@google.com> #16
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 790ebb8dfa2f0e5ffcfc41d88c2cf04288157e67
Author: Ian Lake <ilake@google.com>
Date: Thu Aug 23 10:50:43 2018
Move Fragment's view lifecycle to stopped
The Fragment's view lifecycle should be stopped
when the Fragment's lifecycle is stopped.
Moves the ON_CREATE event to after onViewStateRestored()
and ON_DESTROY event from onDestroyView()
to performDestroyView() to fully mirror the lifecycle.
Test: new testViewLifecycleInFragmentLifecycle() test
Fixes: 113070421
Change-Id: Id03d664fba627f7aab615b76d3e615496e88d6e2
M fragment/src/androidTest/java/androidx/fragment/app/FragmentViewLifecycleTest.java
M fragment/src/main/java/androidx/fragment/app/Fragment.java
https://android-review.googlesource.com/737168
Branch: androidx-master-dev
commit 790ebb8dfa2f0e5ffcfc41d88c2cf04288157e67
Author: Ian Lake <ilake@google.com>
Date: Thu Aug 23 10:50:43 2018
Move Fragment's view lifecycle to stopped
The Fragment's view lifecycle should be stopped
when the Fragment's lifecycle is stopped.
Moves the ON_CREATE event to after onViewStateRestored()
and ON_DESTROY event from onDestroyView()
to performDestroyView() to fully mirror the lifecycle.
Test: new testViewLifecycleInFragmentLifecycle() test
Fixes: 113070421
Change-Id: Id03d664fba627f7aab615b76d3e615496e88d6e2
M fragment/src/androidTest/java/androidx/fragment/app/FragmentViewLifecycleTest.java
M fragment/src/main/java/androidx/fragment/app/Fragment.java
Description
Version used: 28.0.0-rc01
Theme used: n/a
Devices/Android versions reproduced on: Pixel 2.0, Android 8.0
The sample app is an simple activity with a ViewPager of fragments for which each fragment is observing "TestLiveData" subclass of LiveData . When an instance of "TestLiveData" is observed with the fragment as its LifecycleOwner both LiveData.onActive()/onIsactive() is triggered if the app is foregrounded and backgrounded. However, if a Fragment.getViewLifecycleOwner() is provided to observe LiveData.onInactive() is never called.
Simply launch the sample app and notice the log output of "onActive()" and then push the app into the background. You will notice that there is no "onInactive" called. It is however called when cycling thru the ViewPager but shouldn't it be called when the app is backgrounded?