Fragment.getViewLifecycleOwner() does not get stopped when hitting the home button [113070421]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Aug 23, 2018 06:35AM

Artifact used: com.android.support:appcompat-v7:28.0.0-rc01
Version used: 28.0.0-rc01
Theme used: n/a
Devices/Android versions reproduced on: Pixel 2.0, Android 8.0

The sample app is an simple activity with a ViewPager of fragments for which each fragment is observing "TestLiveData" subclass of LiveData . When an instance of "TestLiveData" is observed with the fragment as its LifecycleOwner both LiveData.onActive()/onIsactive() is triggered if the app is foregrounded and backgrounded. However, if a Fragment.getViewLifecycleOwner() is provided to observe LiveData.onInactive() is never called.

Simply launch the sample app and notice the log output of "onActive()" and then push the app into the background. You will notice that there is no "onInactive" called. It is however called when cycling thru the ViewPager but shouldn't it be called when the app is backgrounded?

LiveDataSample.zip

15 MB

Download

Comments

il...@google.com <il...@google.com> Aug 23, 2018 05:49PM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #2Aug 24, 2018 04:09PM

Marked as fixed.

BTW, the source code for this is fairly straightforward. I just added the source into the sample for now, but it would be nicer if we had the function.

From source:

 /**
 * Gets the current navigation back stack entry as a [MutableState]. When the given navController
 * changes the back stack due to a [NavController.navigate] or [NavController.popBackStack] this
 * will trigger a recompose and return the top entry on the back stack.
 *
 * @return a mutable state of the current back stack entry
 */
@Composable
public fun NavController.currentBackStackEntryAsState(): State<NavBackStackEntry?> {
    return currentBackStackEntryFlow.collectAsState(null)
}

as...@gmail.com <as...@gmail.com> #3Oct 13, 2018 05:58PM

Here's the code from my PR if you want to see what I was doing.

ju...@gmail.com <ju...@gmail.com> #4Dec 28, 2018 09:51PM

Project: platform/frameworks/support
Branch: androidx-main

commit 804463f3f416212296133fe53e30b5d5cbc2fba9
Author: stevebower <stevebower@google.com>
Date: Wed Jan 05 15:04:02 2022

Add currentBackStackEntryAsState to Wear Compose Navigation.

Test: Run tests for wear.compose.navigation.

Bug: 212739653

Relnote: "We have added NavController.currentBackStackEntryAsState()
to the Wear.Compose.Navigation library."
Change-Id: If90286c7debe623df926a091f15766abf04f2ecc

M wear/compose/compose-navigation/api/restricted_current.txt
M wear/compose/compose-navigation/api/current.txt
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt
M wear/compose/compose-navigation/api/public_plus_experimental_current.txt
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHostController.kt

https://android-review.googlesource.com/1926189

[Deleted User] <[Deleted User]> #5Feb 20, 2020 08:17AM

Hi Steve, which version of the library will this be released in?

[Deleted User] <[Deleted User]> #6Feb 20, 2020 08:17AM

Never mind, it's in alpha15, missed that. Thanks!

ro...@gmail.com <ro...@gmail.com> #7May 29, 2020 03:22PM

jd...@gmail.com <jd...@gmail.com> #8Sep 8, 2020 07:24PM

https://docs.google.com/spreadsheets/d/1tG4iURcv5pMxKT37SL-ULo3WWbbhi6teJKxL8anHbOo/edit?usp=drive_web ([Sample] Google Analytics Marketing Website_Page 1_Tabla)

re...@gmail.com <re...@gmail.com> #9Jan 2, 2021 10:23AM

Drive way

je...@gmail.com <je...@gmail.com> #10Mar 5, 2021 01:15AM

Hoka

hd...@gmail.com <hd...@gmail.com> #11
Restricted
May 6, 2021 05:53AM

Comment has been deleted.

ba...@gmail.com <ba...@gmail.com> #12May 29, 2021 06:12AM

Comment has been deleted.

Message last modified on May 29, 2021 06:13AM

ch...@gmail.com <ch...@gmail.com> #13Dec 16, 2021 10:57AM

https://drive.google.com/file/d/1Kl_2CzAE284x_-fxyFN7LDc8FHaPP-TY/view?usp=drive_web (978-3-642-24070-6_BookBackMatter (1).pdf)

la...@gmail.com <la...@gmail.com> #14Jan 31, 2022 06:41PM

sh...@gmail.com <sh...@gmail.com> #15Feb 13, 2022 06:35AM

Fortnit

ap...@google.com <ap...@google.com> #16Jan 19, 2023 03:58PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 790ebb8dfa2f0e5ffcfc41d88c2cf04288157e67
Author: Ian Lake <ilake@google.com>
Date: Thu Aug 23 10:50:43 2018

Move Fragment's view lifecycle to stopped

The Fragment's view lifecycle should be stopped
when the Fragment's lifecycle is stopped.

Moves the ON_CREATE event to after onViewStateRestored()
and ON_DESTROY event from onDestroyView()
to performDestroyView() to fully mirror the lifecycle.

Test: new testViewLifecycleInFragmentLifecycle() test
Fixes: 113070421
Change-Id: Id03d664fba627f7aab615b76d3e615496e88d6e2

M fragment/src/androidTest/java/androidx/fragment/app/FragmentViewLifecycleTest.java
M fragment/src/main/java/androidx/fragment/app/Fragment.java

https://android-review.googlesource.com/737168