API Review: HandlerCompat.hasCallbacks(Runnable) [113855676]

Fixed

Feature Request

Status Update

No update yet.

Description

ju...@google.com

created issue on behalf of an...@google.com #1

Sep 4, 2018 02:07PM

We've been reviewing newly added Android APIs, and the following questions/requests came up during the review. Learn more about the API review process, including best-practices for making API changes at <

http://go/android-api-bugs>.
--

Please add.

Comments

an...@google.com <an...@google.com> #2Oct 8, 2019 03:19PM

Android Bug Scrub: This issue has been open for 270 days or pinged by blunderbuss 5 times with no updates. As a result, this issue looks stale to us.

Please help us out! If you are planning to work on this issue within the next year, please reply indicating the timeline you intend to complete the work and remove the "Android Blintz Close Candidate" hotlist. If it is expected for this issue to take multiple years to resolve, please add it to the android_icebox hotlist (

https://b.corp.google.com/hotlists/4240)

Stale issues that aren't removed from the "Android Blintz Close Candidate" will be closed in 7 days, so if you think this should be closed there's no need to do anything. For more information please see go/android-blintz.

If you are not the assignee of this bug, and feel this issue needs to be escalated, please email the components default assignee with the bug number, and what you'd like to escalate.

an...@google.com <an...@google.com> #3Oct 16, 2019 03:23PM

Status: Won't Fix (Obsolete)

This issue has been closed as part of the Android Bug Scrub.
For more information please see go/android-blintz.

ja...@google.com <ja...@google.com> Oct 17, 2019 12:43AM

Status: Assigned (reopened)

an...@google.com <an...@google.com> #4Oct 24, 2019 03:10PM

Status: Won't Fix (Obsolete)

This issue has been closed as part of the Android Bug Scrub.
For more information please see go/android-blintz.

ja...@google.com <ja...@google.com> Oct 29, 2019 12:43AM

Status: Assigned (reopened)

ni...@google.com <ni...@google.com> Apr 30, 2020 04:58PM

Reassigned to al...@google.com.

ni...@google.com <ni...@google.com> #5May 12, 2020 01:29PM

Tagging with a review tag so that Jetpad picks it up

[LIBRARY_API_REVIEW_TAG:core/core/api/1.4.0-alpha01.txt]

al...@google.com <al...@google.com> #6May 12, 2020 02:00PM

Reassigned to ki...@google.com.

"Please add."?

al...@google.com <al...@google.com> #7May 12, 2020 02:02PM

Oh, okay -- it's a feature request to add that method.

ki...@google.com <ki...@google.com> #8May 12, 2020 04:53PM

Handler.hasCallbacks was added in JB timeframe in https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/183519/1/core/java/android/os/Handler.java

It was marked as @hide, so technically we can use reflection on pre-29 versions to get to it. But what would we do ICS? Nothing?

ki...@google.com <ki...@google.com> #9May 12, 2020 04:57PM

And on ICS there is no underlying MessageQueue API to check for runnable callbacks. That was added as part of the same original CL at https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/183519/1/core/java/android/os/MessageQueue.java

Note that we didn't see a single internal or external request to actually expose this API in AndroidX in a backwards compatible way.

al...@google.com <al...@google.com> #10May 12, 2020 05:00PM

It would have to be RequiresApi(JELLY_BEAN), but if the @hide method was on the non-SDK-usage blacklist in P then we're out of luck.

ki...@google.com <ki...@google.com> #11May 26, 2020 09:03PM

Where do I find that blacklist?

al...@google.com <al...@google.com> #12May 26, 2020 09:47PM

You could either check the status manually by searching in a CSV (SDK 29) and TXT (SDK 28):

https://developer.android.com/distribute/best-practices/develop/restrictions-non-sdk-interfaces#determine-list

Or go ahead and write it and then pass the library through veridex:

https://developer.android.com/distribute/best-practices/develop/restrictions-non-sdk-interfaces#test-veridex-tool

ki...@google.com <ki...@google.com> Nov 11, 2020 04:58PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> #13Feb 8, 2021 03:29PM

Accepted by al...@google.com.

It's light-greylist on SDK 28, so we should be able to reflect on SDK 16+.

al...@google.com <al...@google.com> #14Feb 8, 2021 08:28PM

Though if an OEM changed the implementation, we're going to have to throw an exception. It's unlikely, but it's there.

al...@google.com <al...@google.com> #15Mar 8, 2021 08:48PM

Still waiting on core to go back to alpha... This is waiting in aosp/1580773.

ap...@google.com <ap...@google.com> #16Mar 16, 2021 12:31AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7e9c4bfcbd0a3bebc25ec4747922bcf80cd278fe
Author: Alan Viverette <alanv@google.com>
Date: Mon Feb 08 17:41:41 2021

Add compat method for Handler.hasCallbacks()

Fixes UnsafeNewApiCall errors, fixes APIs that were incorrectly targeting
API 16, improves exception logging. Cleans up test formatting.

Relnote: "Adds Handler.hasCallbacks() method for parity with platform SDK"
Fixes: 113855676
Test: HandlerCompatTest#testHasCallbacks, HandlerCompatTest
Change-Id: Idce1c9fbe0d93bd9ebcb26716a63834bb1c4c12d

M core/core/api/current.txt
M core/core/api/public_plus_experimental_current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/os/HandlerCompatTest.java
M core/core/src/main/java/androidx/core/os/HandlerCompat.java

https://android-review.googlesource.com/1580773