API Review: HandlerCompat.hasCallbacks(Runnable) [113855676]

Fixed

Feature Request

Status Update

No update yet.

Description

ju...@google.com

created issue on behalf of an...@google.com #1

Sep 4, 2018 02:07PM

We've been reviewing newly added Android APIs, and the following questions/requests came up during the review. Learn more about the API review process, including best-practices for making API changes at <

http://go/android-api-bugs>.
--

Please add.

Comments

an...@google.com <an...@google.com> #2Oct 8, 2019 03:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

an...@google.com <an...@google.com> #3Oct 16, 2019 03:23PM

Status: Won't Fix (Obsolete)

This issue has been closed as part of the Android Bug Scrub.
For more information please see go/android-blintz.

ja...@google.com <ja...@google.com> Oct 17, 2019 12:43AM

Status: Assigned (reopened)

an...@google.com <an...@google.com> #4Oct 24, 2019 03:10PM

Status: Won't Fix (Obsolete)

This issue has been closed as part of the Android Bug Scrub.
For more information please see go/android-blintz.

ja...@google.com <ja...@google.com> Oct 29, 2019 12:43AM

Status: Assigned (reopened)

ni...@google.com <ni...@google.com> Apr 30, 2020 04:58PM

Reassigned to al...@google.com.

ni...@google.com <ni...@google.com> #5May 12, 2020 01:29PM

Tagging with a review tag so that Jetpad picks it up

[LIBRARY_API_REVIEW_TAG:core/core/api/1.4.0-alpha01.txt]

al...@google.com <al...@google.com> #6May 12, 2020 02:00PM

Reassigned to ki...@google.com.

"Please add."?

al...@google.com <al...@google.com> #7May 12, 2020 02:02PM

Oh, okay -- it's a feature request to add that method.

ki...@google.com <ki...@google.com> #8May 12, 2020 04:53PM

Handler.hasCallbacks was added in JB timeframe in https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/183519/1/core/java/android/os/Handler.java

It was marked as @hide, so technically we can use reflection on pre-29 versions to get to it. But what would we do ICS? Nothing?

ki...@google.com <ki...@google.com> #9May 12, 2020 04:57PM

And on ICS there is no underlying MessageQueue API to check for runnable callbacks. That was added as part of the same original CL at https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/183519/1/core/java/android/os/MessageQueue.java

Note that we didn't see a single internal or external request to actually expose this API in AndroidX in a backwards compatible way.

al...@google.com <al...@google.com> #10May 12, 2020 05:00PM

It would have to be RequiresApi(JELLY_BEAN), but if the @hide method was on the non-SDK-usage blacklist in P then we're out of luck.

ki...@google.com <ki...@google.com> #11May 26, 2020 09:03PM

Where do I find that blacklist?

al...@google.com <al...@google.com> #12May 26, 2020 09:47PM

You could either check the status manually by searching in a CSV (SDK 29) and TXT (SDK 28):

https://developer.android.com/distribute/best-practices/develop/restrictions-non-sdk-interfaces#determine-list

Or go ahead and write it and then pass the library through veridex:

https://developer.android.com/distribute/best-practices/develop/restrictions-non-sdk-interfaces#test-veridex-tool

ki...@google.com <ki...@google.com> Nov 11, 2020 04:58PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> #13Feb 8, 2021 03:29PM

Accepted by al...@google.com.

It's light-greylist on SDK 28, so we should be able to reflect on SDK 16+.

al...@google.com <al...@google.com> #14Feb 8, 2021 08:28PM

Though if an OEM changed the implementation, we're going to have to throw an exception. It's unlikely, but it's there.

al...@google.com <al...@google.com> #15Mar 8, 2021 08:48PM

Still waiting on core to go back to alpha... This is waiting in aosp/1580773.

ap...@google.com <ap...@google.com> #16Mar 16, 2021 12:31AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7e9c4bfcbd0a3bebc25ec4747922bcf80cd278fe
Author: Alan Viverette <alanv@google.com>
Date: Mon Feb 08 17:41:41 2021

Add compat method for Handler.hasCallbacks()

Fixes UnsafeNewApiCall errors, fixes APIs that were incorrectly targeting
API 16, improves exception logging. Cleans up test formatting.

Relnote: "Adds Handler.hasCallbacks() method for parity with platform SDK"
Fixes: 113855676
Test: HandlerCompatTest#testHasCallbacks, HandlerCompatTest
Change-Id: Idce1c9fbe0d93bd9ebcb26716a63834bb1c4c12d

M core/core/api/current.txt
M core/core/api/public_plus_experimental_current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/os/HandlerCompatTest.java
M core/core/src/main/java/androidx/core/os/HandlerCompat.java

https://android-review.googlesource.com/1580773