Fixed
Status Update
Comments
an...@gmail.com <an...@gmail.com> #2
See also
an...@gmail.com <an...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 1a48f33d2d01d135a0d647f83b1baaac10499ef0
Author: Chris Craik <ccraik@google.com>
Date: Tue Jan 25 12:35:23 2022
Clarify FrameTimingMetric names
Fixes: 216337830
Relnote: "Renamed FrameCpuTime -> FrameDurationCpu, FrameUiTime -> FrameDurationUi to clarify these are durations, not timestamps, and to match prefixes."
Test: ./gradlew benchmark:benchmark-common:cC
Test: TrivialListScrollBenchmark
Change-Id: I0eba35542431905ab926f5dc7db4ab6e292fde69
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
https://android-review.googlesource.com/1960660
Branch: androidx-main
commit 1a48f33d2d01d135a0d647f83b1baaac10499ef0
Author: Chris Craik <ccraik@google.com>
Date: Tue Jan 25 12:35:23 2022
Clarify FrameTimingMetric names
Fixes: 216337830
Relnote: "Renamed FrameCpuTime -> FrameDurationCpu, FrameUiTime -> FrameDurationUi to clarify these are durations, not timestamps, and to match prefixes."
Test: ./gradlew benchmark:benchmark-common:cC
Test: TrivialListScrollBenchmark
Change-Id: I0eba35542431905ab926f5dc7db4ab6e292fde69
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
ra...@google.com <ra...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 97515b8c7b3e94e5ec110d9e8c9e3e9baf1c85c1
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Sep 23 17:29:09 2019
Migrate WorkDatabase to the no-backup directory.
Fixes: b/114808216
Test: Added unit tests.
Change-Id: Ic8d07af37f548148c48a94bb40c8e6459bf95f08
M work/workmanager-benchmark/src/androidTest/java/androidx/work/benchmark/InitializeBenchmark.kt
A work/workmanager/src/androidTest/java/androidx/work/WorkDatabasePathHelperTest.kt
M work/workmanager/src/main/java/androidx/work/impl/WorkDatabase.java
A work/workmanager/src/main/java/androidx/work/impl/WorkDatabasePathHelper.java
M work/workmanager/src/main/java/androidx/work/impl/utils/ForceStopRunnable.java
https://android-review.googlesource.com/1127243
https://goto.google.com/android-sha1/97515b8c7b3e94e5ec110d9e8c9e3e9baf1c85c1
Branch: androidx-master-dev
commit 97515b8c7b3e94e5ec110d9e8c9e3e9baf1c85c1
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Sep 23 17:29:09 2019
Migrate WorkDatabase to the no-backup directory.
Fixes:
Test: Added unit tests.
Change-Id: Ic8d07af37f548148c48a94bb40c8e6459bf95f08
M work/workmanager-benchmark/src/androidTest/java/androidx/work/benchmark/InitializeBenchmark.kt
A work/workmanager/src/androidTest/java/androidx/work/WorkDatabasePathHelperTest.kt
M work/workmanager/src/main/java/androidx/work/impl/WorkDatabase.java
A work/workmanager/src/main/java/androidx/work/impl/WorkDatabasePathHelper.java
M work/workmanager/src/main/java/androidx/work/impl/utils/ForceStopRunnable.java
[Deleted User] <[Deleted User]> #5
Hi,
I've been following this issue as I've had similar issues, and I can't see how the linked commit will fix it.
On those 2 lines here:
String path = WorkDatabasePathHelper.getDatabasePath(context).getPath();
builder = Room.databaseBuilder(context, WorkDatabase.class, path);
unless there are other changes being done to the Room.databaseBuilder, the 3rd parameter `path` is not a file path, it's a database name.
"@param name The name of the database file."
https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/room/runtime/src/main/java/androidx/room/Room.java#36
That way you're simply moving the database from:
/data/data/<package-name>/databases/androidx.work.workdb
to
/data/data/<package-name>/databases/data/data/<package-name>/no_backup/androidx.work.workdb
I've been following this issue as I've had similar issues, and I can't see how the linked commit will fix it.
On those 2 lines here:
String path = WorkDatabasePathHelper.getDatabasePath(context).getPath();
builder = Room.databaseBuilder(context, WorkDatabase.class, path);
unless there are other changes being done to the Room.databaseBuilder, the 3rd parameter `path` is not a file path, it's a database name.
"@param name The name of the database file."
That way you're simply moving the database from:
/data/data/<package-name>/databases/androidx.work.workdb
to
/data/data/<package-name>/databases/data/data/<package-name>/no_backup/androidx.work.workdb
ra...@google.com <ra...@google.com> #6
The 3rd parameter is actually a path. The documentation is not clear about that.
As you can tell we move the database to the no_backup directory and that fixes the backup problem because the no_backup directory does not get backed up.
As you can tell we move the database to the no_backup directory and that fixes the backup problem because the no_backup directory does not get backed up.
su...@google.com <su...@google.com> #7
Actually, I'm not sure if this is fixed. WorkDatabase.DB_NAME doesn't have the right path. You're simply moving it but I'm not sure where you're changing it on creation.
Description
No description yet.