[Feature Request] Add a method like Data#containsKey() [117136838]

Fixed

Bug

Status Update

No update yet.

Description

gr...@signal.org

created issue #1

Oct 2, 2018 07:03PM

I want to be able to assert the state of the input data in my workers rather than fall back to some default value. This is particularly important for booleans, since there's no default value that you can assume is invalid. Thanks!

Comments

gr...@signal.org <gr...@signal.org> #2Oct 2, 2018 07:26PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ra...@google.com <ra...@google.com> #3Oct 2, 2018 09:49PM

Assigned to ra...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ra...@google.com <ra...@google.com> #4Oct 2, 2018 09:54PM

deleted

m6...@gmail.com <m6...@gmail.com> #5Oct 3, 2018 03:41PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

gr...@signal.org <gr...@signal.org> #6Oct 3, 2018 04:04PM

Replying to

comment #5

The goal of the methods would be to allow the user to assert the state of the input data before retrieving anything. The idea is that the Worker is making an assumption that there is a value of a certain type in the input data, and it wants to assert that their assumption is true. That'd require more than just knowing if a key is present -- it would also require knowing there is a key with a specific datatype present.

as...@gmail.com <as...@gmail.com> #7Jun 18, 2019 12:07AM

I agree that adding a containsKey() method could be helpful. However, here's a different feature request that I believe would satisfy the OP's needs:

https://issuetracker.google.com/issues/135473444.

gr...@signal.org <gr...@signal.org> #8Jun 27, 2019 02:50PM

That would indeed be equally useful.

ap...@google.com <ap...@google.com> #9Aug 7, 2019 12:33AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9e5c3eea6ab3df3243d4dd2c70c4986e0a8e8c3b
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Aug 06 14:55:04 2019

Add Data#containsKey API.

* Add Kotlin extensions with reified types.

Test: Added unit tests.
Fixes:

b/117136838

Change-Id: Ie13594cad362912986c8b5786e41672c422245f2

M work/workmanager-ktx/api/2.3.0-alpha01.txt
M work/workmanager-ktx/api/current.txt
M work/workmanager-ktx/api/restricted_2.3.0-alpha01.txt
M work/workmanager-ktx/api/restricted_current.txt
M work/workmanager-ktx/src/androidTest/java/androidx/work/DataTest.kt
M work/workmanager-ktx/src/main/java/androidx/work/Data.kt
M work/workmanager/api/2.3.0-alpha01.txt
M work/workmanager/api/current.txt
M work/workmanager/src/main/java/androidx/work/Data.java

https://android-review.googlesource.com/1096671

https://goto.google.com/android-sha1/9e5c3eea6ab3df3243d4dd2c70c4986e0a8e8c3b