[Feature Request] Add a method like Data#containsKey() [117136838]

Fixed

Bug

Status Update

No update yet.

Description

gr...@signal.org

created issue #1

Oct 2, 2018 07:03PM

I want to be able to assert the state of the input data in my workers rather than fall back to some default value. This is particularly important for booleans, since there's no default value that you can assume is invalid. Thanks!

Comments

gr...@signal.org <gr...@signal.org> #2Oct 2, 2018 07:26PM

https://android-review.googlesource.com/c/platform/frameworks/support/+/1092870

ra...@google.com <ra...@google.com> #3Oct 2, 2018 09:49PM

Assigned to ra...@google.com.

Thank you for the quick fix.
Is there an ETA for the next release?

ra...@google.com <ra...@google.com> #4Oct 2, 2018 09:54PM

2.2.0-rc01 should be out this week.

m6...@gmail.com <m6...@gmail.com> #5Oct 3, 2018 03:41PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a1957df3709a06f4e6482fb0e4d39ded4f230a70
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Jul 29 09:48:05 2019

Workaround NPE in PersistableBundle.getExtras().

Test: Existing unit tests pass. Ran integration test app.
Fixes:

b/138441699

Change-Id: I0b48e0009a7d83c343a3d26112b94c057470c281

M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java

https://android-review.googlesource.com/1092870

https://goto.google.com/android-sha1/a1957df3709a06f4e6482fb0e4d39ded4f230a70

gr...@signal.org <gr...@signal.org> #6Oct 3, 2018 04:04PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6206758647365632/#/cherrypickHistory/all)
Created: 2019-07-29 19:41:55.445144+00:00
Changes: aosp/1092870

as...@gmail.com <as...@gmail.com> #7Jun 18, 2019 12:07AM

I agree that adding a containsKey() method could be helpful. However, here's a different feature request that I believe would satisfy the OP's needs:

https://issuetracker.google.com/issues/135473444.

gr...@signal.org <gr...@signal.org> #8Jun 27, 2019 02:50PM

That would indeed be equally useful.

ap...@google.com <ap...@google.com> #9Aug 7, 2019 12:33AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9e5c3eea6ab3df3243d4dd2c70c4986e0a8e8c3b
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Aug 06 14:55:04 2019

Add Data#containsKey API.

* Add Kotlin extensions with reified types.

Test: Added unit tests.
Fixes:

b/117136838

Change-Id: Ie13594cad362912986c8b5786e41672c422245f2

M work/workmanager-ktx/api/2.3.0-alpha01.txt
M work/workmanager-ktx/api/current.txt
M work/workmanager-ktx/api/restricted_2.3.0-alpha01.txt
M work/workmanager-ktx/api/restricted_current.txt
M work/workmanager-ktx/src/androidTest/java/androidx/work/DataTest.kt
M work/workmanager-ktx/src/main/java/androidx/work/Data.kt
M work/workmanager/api/2.3.0-alpha01.txt
M work/workmanager/api/current.txt
M work/workmanager/src/main/java/androidx/work/Data.java

https://android-review.googlesource.com/1096671

https://goto.google.com/android-sha1/9e5c3eea6ab3df3243d4dd2c70c4986e0a8e8c3b