IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date:   Wed Sep 18 16:55:49 2019

    Change the way to detect mismatch between POJO and query
   
    This fixes cursor mismatch warnings with expandProjection.
   
    Bug: 140759491
    Test: QueryMethodProcessorTest
    Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
  Created: 2019-10-14 17:23:42.610596+00:00
  Changes: aosp/1123258
 

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date:   Thu Apr 16 16:47:05 2020

    Re-factor how errors are dismissed when query is re-written
   
    This CL changes how we handle errors/warnings if query is
    re-written.
    There was a bug in expandProjection where we would report warnings
    for things that Room already fixes automatically (b/140759491).
    The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
    solved it by deferring validating of columns until after re-write
    decision is made. Unfortunately, this required changing PojoRowAdapter
    to have a dummy mapping until it is validating, make it hard to use
    as it does have a non-null mapping which is not useful.
   
    This CL partially reverts that change and instead rely on the log
    deferring logic we have in Context. This way, we don't need to break
    the stability of PojoRowAdapter while still having the ability to
    drop warnings that room fixes. This will also play nicer when we
    have different query re-writing options that can use more information
    about the query results.
   
    Bug: 153387066
    Bug: 140759491
    Test: existing tests pass
    Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M       room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

Replying to #2
If I already know the type of the value that the key refers to. Then I think it's quite safe to assume that the user will always know the value type when they check the existence of a key/? I think this would be an unnecessary verbosity.

Replying to comment #5
The goal of the methods would be to allow the user to assert the state of the input data before retrieving anything. The idea is that the Worker is making an assumption that there is a value of a certain type in the input data, and it wants to assert that their assumption is true. That'd require more than just knowing if a key is present -- it would also require knowing there is a key with a specific datatype present.

I agree that adding a containsKey() method could be helpful. However, here's a different feature request that I believe would satisfy the OP's needs: https://issuetracker.google.com/issues/135473444.

That would indeed be equally useful.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9e5c3eea6ab3df3243d4dd2c70c4986e0a8e8c3b
Author: Rahul Ravikumar <rahulrav@google.com>
Date:   Tue Aug 06 14:55:04 2019

    Add Data#containsKey API.
   
    * Add Kotlin extensions with reified types.
   
    Test: Added unit tests.
    Fixes: b/117136838
   
    Change-Id: Ie13594cad362912986c8b5786e41672c422245f2

M       work/workmanager-ktx/api/2.3.0-alpha01.txt
M       work/workmanager-ktx/api/current.txt
M       work/workmanager-ktx/api/restricted_2.3.0-alpha01.txt
M       work/workmanager-ktx/api/restricted_current.txt
M       work/workmanager-ktx/src/androidTest/java/androidx/work/DataTest.kt
M       work/workmanager-ktx/src/main/java/androidx/work/Data.kt
M       work/workmanager/api/2.3.0-alpha01.txt
M       work/workmanager/api/current.txt
M       work/workmanager/src/main/java/androidx/work/Data.java

https://android-review.googlesource.com/1096671
https://goto.google.com/android-sha1/9e5c3eea6ab3df3243d4dd2c70c4986e0a8e8c3b