Fixed
Status Update
Comments
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 8d1537b867a7e2956915976b42ec923db4dd0eb0
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 03 09:30:27 2018
Call overridePendingTransition after startActivity
overridePendingTransition only operates on pending
startActivity calls which means that the startActivity
call needs to happen first, followed by the call
to overridePendingTransition.
Test: testapp displays the right animation
BUG: 117145284
Change-Id: I9b7f66359405c2cd5ec58be8542eab00724f6539
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
https://android-review.googlesource.com/776765
https://goto.google.com/android-sha1/8d1537b867a7e2956915976b42ec923db4dd0eb0
Branch: androidx-master-dev
commit 8d1537b867a7e2956915976b42ec923db4dd0eb0
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 03 09:30:27 2018
Call overridePendingTransition after startActivity
overridePendingTransition only operates on pending
startActivity calls which means that the startActivity
call needs to happen first, followed by the call
to overridePendingTransition.
Test: testapp displays the right animation
BUG: 117145284
Change-Id: I9b7f66359405c2cd5ec58be8542eab00724f6539
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
il...@google.com <il...@google.com> #3
This is fixed and will be available in 1.0.0-alpha07
Description
Version used: 1.0.6-alpha
Previous version without bug: 1.0.4-alpha
Devices/Android versions reproduced on: Samsung Galaxy Edge 7, Android 8.0.0
Navigation doesn't take into account
app:enterAnim
app:exitAnim
that are set for action to activity:
<navigation>
<fragment android:id="@+id/mainFragment">
<action
android:id="@+id/action_mainFragment_to_activity2"
app:destination="@id/activity2"
app:enterAnim="@anim/view_slide_bottom_in"
app:exitAnim="@anim/no_animation"/>
</fragment>
<activity android:id="@+id/activity2"/>
<navigation/>
This doesn't work:
NavHostFragment.findNavController(this).navigate(R.id.action_mainFragment_to_activity2)
But if I set directly with ActivityOptions it works:
NavHostFragment.findNavController(this)
.navigate(R.id.action_mainFragment_to_activity2, null, null,
ActivityNavigator.Extras(
ActivityOptionsCompat.makeCustomAnimation(activity!!, R.anim.view_slide_bottom_in, R.anim.no_animation)))
Example project to reproduce issue
It is expected to work the same.