Making matchDeeplink public or providing a way to check if a URI matches any deeplink or not [117437718]

Fixed

Feature Request

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Oct 9, 2018 11:39PM

Component used: navigation
Version used: 1.0.0-alpha05
Devices/Android versions reproduced on: N/A

There are use-cases that the app's deeplink will capture a more generic link and the try to dynamically handle it based on its parameters and such. One of the main factor for such approach is to be able to check if a specific uri is supported by the deeplinking in the graph or not. The `matchDeepLink()` method in `NavDestination` already does that but its a protected function.

Feature request: either make the matchDeeplink a public method or provide a boolean method to check if a uri is matched with any of the deeplinks in the app.

Comments

il...@google.com <il...@google.com> #2Oct 10, 2018 12:55AM

Assigned to il...@google.com.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

[Deleted User] <[Deleted User]> #3Oct 10, 2018 05:01PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

th...@yaacomm.com <th...@yaacomm.com> #4Nov 1, 2018 04:07PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

jb...@google.com <jb...@google.com> Apr 17, 2019 09:24PM

Reassigned to jb...@google.com.

ap...@google.com <ap...@google.com> #5Apr 24, 2019 09:12PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

il...@google.com <il...@google.com> #6Apr 25, 2019 09:00PM

Marked as fixed.

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

Issue 117437718