Fixed
Status Update
No update yet.
Comments
ha...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ha...@gmail.com
ha...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 288afbcaeaf69c9f340e941154ed8aad05f0442e
Author: Sumir Kataria <sumir@google.com>
Date: Wed Oct 17 11:24:33 2018
Lazily load Preferences.
Removes a potential disk IO on startup (which I haven't been able to
actually get to trigger a strict mode violation).
Changed integration test app to manually initialize WM.
Bug: 117796731
Test: Ran existing tests.
Change-Id: Ie8c77b4145aeb8a2e9a0b05e0cb20881cf4abc7e
M work/integration-tests/testapp/src/main/AndroidManifest.xml
A work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/TestApplication.java
M work/workmanager/src/main/java/androidx/work/impl/utils/Preferences.java
https://android-review.googlesource.com/792525
https://goto.google.com/android-sha1/288afbcaeaf69c9f340e941154ed8aad05f0442e
Branch: androidx-master-dev
commit 288afbcaeaf69c9f340e941154ed8aad05f0442e
Author: Sumir Kataria <sumir@google.com>
Date: Wed Oct 17 11:24:33 2018
Lazily load Preferences.
Removes a potential disk IO on startup (which I haven't been able to
actually get to trigger a strict mode violation).
Changed integration test app to manually initialize WM.
Bug: 117796731
Test: Ran existing tests.
Change-Id: Ie8c77b4145aeb8a2e9a0b05e0cb20881cf4abc7e
M work/integration-tests/testapp/src/main/AndroidManifest.xml
A work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/TestApplication.java
M work/workmanager/src/main/java/androidx/work/impl/utils/Preferences.java
su...@google.com
su...@twofortyfouram.com
Thank you for the quick response!
If it helps, this is the strict mode violation stacktrace I get:
StrictMode policy violation; ~duration=94 ms: android.os.strictmode.DiskReadViolation
at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1504)
at java.io.UnixFileSystem.checkAccess(UnixFileSystem.java:251)
at java.io.File.exists(File.java:815)
at android.app.ContextImpl.ensurePrivateDirExists(ContextImpl.java:605)
at android.app.ContextImpl.ensurePrivateDirExists(ContextImpl.java:596)
at android.app.ContextImpl.getPreferencesDir(ContextImpl.java:552)
at android.app.ContextImpl.getSharedPreferencesPath(ContextImpl.java:747)
at android.app.ContextImpl.getSharedPreferences(ContextImpl.java:400)
at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:174)
at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:174)
at androidx.work.impl.utils.Preferences.<init>(Preferences.java:45)
at androidx.work.impl.WorkManagerImpl.<init>(WorkManagerImpl.java:194)
at androidx.work.impl.WorkManagerImpl.<init>(WorkManagerImpl.java:162)
at androidx.work.impl.WorkManagerImpl.initialize(WorkManagerImpl.java:138)
at androidx.work.WorkManager.initialize(WorkManager.java:158)
at com.twofortyfouram.app.work.WorkSetup.setupWorkHelper(WorkSetup.java:70)
at com.twofortyfouram.app.work.WorkSetup.setupWork(WorkSetup.java:59)
at com.twofortyfouram.app.ApplicationImpl.onCreate(ApplicationImpl.java:89)
at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1154)
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5871)
at android.app.ActivityThread.access$1100(ActivityThread.java:199)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1650)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
If it helps, this is the strict mode violation stacktrace I get:
StrictMode policy violation; ~duration=94 ms: android.os.strictmode.DiskReadViolation
at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1504)
at java.io.UnixFileSystem.checkAccess(UnixFileSystem.java:251)
at java.io.File.exists(File.java:815)
at android.app.ContextImpl.ensurePrivateDirExists(ContextImpl.java:605)
at android.app.ContextImpl.ensurePrivateDirExists(ContextImpl.java:596)
at android.app.ContextImpl.getPreferencesDir(ContextImpl.java:552)
at android.app.ContextImpl.getSharedPreferencesPath(ContextImpl.java:747)
at android.app.ContextImpl.getSharedPreferences(ContextImpl.java:400)
at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:174)
at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:174)
at androidx.work.impl.utils.Preferences.<init>(Preferences.java:45)
at androidx.work.impl.WorkManagerImpl.<init>(WorkManagerImpl.java:194)
at androidx.work.impl.WorkManagerImpl.<init>(WorkManagerImpl.java:162)
at androidx.work.impl.WorkManagerImpl.initialize(WorkManagerImpl.java:138)
at androidx.work.WorkManager.initialize(WorkManager.java:158)
at com.twofortyfouram.app.work.WorkSetup.setupWorkHelper(WorkSetup.java:70)
at com.twofortyfouram.app.work.WorkSetup.setupWork(WorkSetup.java:59)
at com.twofortyfouram.app.ApplicationImpl.onCreate(ApplicationImpl.java:89)
at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1154)
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5871)
at android.app.ActivityThread.access$1100(ActivityThread.java:199)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1650)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
su...@twofortyfouram.com
Reproduced with alpha 10.
Description
Version used: Alpha 10
Devices/Android versions reproduced on: All
WorkManager performs disk IO on the main thread during application startup, as it touches disk for its SharedPreferences file. Ideally this would be done in a background thread to avoid adding delays to app launch.
I was able to identify this by removing the auto initialization ContentProvider via the manifest merger, enabling strict mode in Application.onCreate(), and then manually initializing WorkManager after strict mode was turned on.