Improve Application packaging performance [118363127]

Fixed

Bug

Status Update

No update yet.

Description

ku...@google.com

created issue #1

Oct 24, 2018 09:14AM

Investigate and speed up if possible the performance of application packaging (APK)

Comments

ku...@google.com <ku...@google.com> Oct 24, 2018 09:14AM

Accepted by ku...@google.com.

ap...@google.com <ap...@google.com> #2Jan 8, 2019 11:26PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3450709

Suppress deprecate warning in AbstractSavedStateViewModelFactory tests

Expand for full commit details

Suppress deprecate warning in AbstractSavedStateViewModelFactory tests 
 
Test: N/A 
Bug: 388590327 
Change-Id: Ibe2f04f4cb46f7d19d7fcab22ba2cecb4c82c68c

Files:

M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/SavedStateFactoryTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/ViewModelsWithStateTest.kt

Hash: c944a864317d80aeae8c5ee5812eb20eb1e3d0a8
Date: Mon Jan 13 17:39:17 2025

ap...@google.com <ap...@google.com> #3Jan 30, 2019 10:49AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3450349

Deprecate AbstractSavedStateViewModelFactory in favor of CreationExtras API

Expand for full commit details

Deprecate AbstractSavedStateViewModelFactory in favor of CreationExtras API 
 
`AbstractSavedStateViewModelFactory` is deprecated as it creates a `SavedStateHandle` for every `ViewModel`, causing unnecessary overhead. Use `ViewModelProvider.Factory` with `CreationExtras.createSavedStateHandle` instead for more efficient `ViewModel` creation. 
 
- Updated KDoc with deprecation details and alternatives. 
- Added `@Deprecated` annotation. 
 
RelNote: "`AbstractSavedStateViewModelFactory` is deprecated as it creates a `SavedStateHandle` for every `ViewModel`, causing unnecessary overhead. Use `ViewModelProvider.Factory` with `CreationExtras.createSavedStateHandle` instead for more efficient `ViewModel` creation." 
Test: N/A 
Bug: 388590327 
Change-Id: Ia920b66ccabde85a105cf4e6f80aa980270098ee

Files:

M lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/AbstractSavedStateViewModelFactory.android.kt

Hash: a3dcd46d7c08fa2d407aa9f8f91fb181aa342cc8
Date: Mon Jan 13 14:45:34 2025

ap...@google.com <ap...@google.com> #4Feb 22, 2019 05:03PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.0-alpha09
androidx.lifecycle:lifecycle-viewmodel-savedstate-android:2.9.0-alpha09
androidx.lifecycle:lifecycle-viewmodel-savedstate-desktop:2.9.0-alpha09
androidx.lifecycle:lifecycle-viewmodel-savedstate-iosarm64:2.9.0-alpha09
androidx.lifecycle:lifecycle-viewmodel-savedstate-iossimulatorarm64:2.9.0-alpha09
androidx.lifecycle:lifecycle-viewmodel-savedstate-iosx64:2.9.0-alpha09
androidx.lifecycle:lifecycle-viewmodel-savedstate-linuxarm64:2.9.0-alpha09
androidx.lifecycle:lifecycle-viewmodel-savedstate-linuxx64:2.9.0-alpha09
androidx.lifecycle:lifecycle-viewmodel-savedstate-macosarm64:2.9.0-alpha09
androidx.lifecycle:lifecycle-viewmodel-savedstate-macosx64:2.9.0-alpha09

ap...@google.com <ap...@google.com> #5Feb 26, 2019 09:07PM

Project: platform/tools/apksig
Branch: master

commit 6d7f9746110c5a0d9f83863321fcbd044abb7d8e
Author: Fedor Kudasov <kudasov@google.com>
Date: Mon Feb 25 08:49:19 2019

Add @RunWith for test

Bug: 118363127
Test: RandomAccessFileDataSourceTest

Change-Id: If5713b1395f63c27a2c76813dacb99aba9b16028

M src/test/java/com/android/apksig/internal/util/RandomAccessFileDataSourceTest.java

https://android-review.googlesource.com/910794

https://goto.google.com/android-sha1/6d7f9746110c5a0d9f83863321fcbd044abb7d8e

ap...@google.com <ap...@google.com> #6Mar 6, 2019 10:47AM

Project: platform/tools/apksig
Branch: master

commit 9865fe0c45da84e5dae17b42055ebf652df781c5
Author: Fedor Kudasov <kudasov@google.com>
Date: Wed Feb 27 20:56:31 2019

Parallel calculation of v2 signatures

Bug: 118363127
Test: ApkSigningBlockUtilsTest

Change-Id: Ieb858250e08cd8fed1cd074ff40ab5a6bf751670

M src/main/java/com/android/apksig/internal/apk/ApkSigningBlockUtils.java
A src/test/java/com/android/apksig/internal/apk/ApkSigningBlockUtilsTest.java

https://android-review.googlesource.com/913975

https://goto.google.com/android-sha1/9865fe0c45da84e5dae17b42055ebf652df781c5

ap...@google.com <ap...@google.com> #7Mar 8, 2019 07:41PM

Project: platform/tools/apksig
Branch: master

commit b6b4a0a9a66e6afd49413b5d611c14e4b4d43802
Author: Fedor Kudasov <kudasov@google.com>
Date: Fri Mar 08 17:06:21 2019

Remove explicit concurrency from apksig implementation

Bug: 118363127
Test: ApkSigningBlockUtilsTest

Change-Id: I4fb4eaa7af1167b38c6e954184ee5701878d6f16

M src/main/java/com/android/apksig/ApkSignerEngine.java
M src/main/java/com/android/apksig/ApkVerifier.java
M src/main/java/com/android/apksig/DefaultApkSignerEngine.java
M src/main/java/com/android/apksig/internal/apk/ApkSigningBlockUtils.java
M src/main/java/com/android/apksig/internal/apk/v2/V2SchemeSigner.java
M src/main/java/com/android/apksig/internal/apk/v2/V2SchemeVerifier.java
M src/main/java/com/android/apksig/internal/apk/v3/V3SchemeSigner.java
M src/main/java/com/android/apksig/internal/apk/v3/V3SchemeVerifier.java
A src/main/java/com/android/apksig/util/RunnablesExecutor.java
A src/main/java/com/android/apksig/util/RunnablesProvider.java
M src/test/java/com/android/apksig/internal/apk/ApkSigningBlockUtilsTest.java

https://android-review.googlesource.com/923517

https://goto.google.com/android-sha1/b6b4a0a9a66e6afd49413b5d611c14e4b4d43802

ap...@google.com <ap...@google.com> #8Apr 5, 2019 09:54AM

Project: platform/tools/apksig
Branch: master

commit c4ee3da00ba966bdfaae4062646b513881d1cc01
Author: Fedor Kudasov <kudasov@google.com>
Date: Fri Mar 29 19:18:08 2019

Refactor RunnablesExecutor

- replace getRunnable with createRunnable
- remove unsued imports

Bug: 118363127
Test: all tests should pass

Change-Id: I00f315cde0c3597cbab67060385cd20e7cf616b1

M src/main/java/com/android/apksig/internal/apk/ApkSigningBlockUtils.java
M src/main/java/com/android/apksig/util/RunnablesExecutor.java
M src/main/java/com/android/apksig/util/RunnablesProvider.java
M src/test/java/com/android/apksig/internal/apk/ApkSigningBlockUtilsTest.java

https://android-review.googlesource.com/937221

https://goto.google.com/android-sha1/c4ee3da00ba966bdfaae4062646b513881d1cc01

ku...@google.com <ku...@google.com> May 2, 2019 10:15AM

Marked as fixed.