IssueTracker

The R8 build does include these files in our jar and they are not used/needed. I'll amend our build to avoid including them and merge it to the release branches.

Project: r8
Branch: master

commit 80533c96c4561ab997f18ce65dd2c0c6a37a33b5
Author: Ian Zerny <zerny@google.com>
Date:   Thu Jan 24 10:32:09 2019

    Don't include kotlin module files in distribution.
   
    Bug: 123310328
    Change-Id: Ie70d4b15f08ffc0e7b754c558079002bd6a84334

M       build.gradle

https://r8-review.googlesource.com/33381

Project: r8
Branch: d8-1.3

commit 73a2e504b0edd45eac64b6f242346b2793eae1fe
Author: Søren Gjesse <sgjesse@google.com>
Date:   Fri Jan 25 09:23:25 2019

    Version 1.3.54
   
    Manually applied: Don't include kotlin module files in distribution.
    CL: https://r8-review.googlesource.com/c/r8/+/33381
   
    Bug: 123310328
    Change-Id: Ifa5057f0c09d864295e200c287fb3d54cd3c79bf

M       build.gradle
M       src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/33485

Project: r8
Branch: d8-1.4

commit 2fe3fcb0dc21ed70eb37cc74aae247deffc90d29
Author: Søren Gjesse <sgjesse@google.com>
Date:   Fri Jan 25 09:12:36 2019

    Version 1.4.30
   
   
    Cherry-pick: Don't include kotlin module files in distribution.
    CL: https://r8-review.googlesource.com/c/r8/+/33381
   
    Bug: 123310328
    Change-Id: I92dce45d6c031f2dd58780b0278a188142b21523

M       build.gradle
M       src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/33483

This change has landed in studio-3.3-dev and studio-3.4-dev. It has not yet landed in master, but will get there early next week when we do the weekly roll of R8 into studio.

Fantastic!

This still "NeedsInfo"?

Thank you for reporting this! We have a fix to this that will be available in Android gradle plugin 3.3.1.

Thank you for looking into this. Unfortunately it does not seem to be fixed with 3.3.1. In the project I submitted, the relative path to external-lib.hpp cannot be resolved from external-lib.cpp. The "base path" / workingDirectoryOrdinal in android_gradle_build.json for that file refers to app/.externalNativeBuild/cmake/debug/x86/external-lib but the include flags are relative to app/.externalNativeBuild/cmake/debug/x86, so the headers are not found by IDE and symbols cannot be resolved.

It is nice to see that something related to C++ has been fixed or attempted at least. C++ support in Android Studio is very lacking in every aspect. Please devote a few releases to improving the C++ support and integration in the IDE.

Hello Google people.

Do you have an update on this issue?  We are really suffering in our project as we have no symbols in C++, so we cannot do symbol lookups to find the definition of a variable, class, method etc. and we cannot put breakpoints on our code.

Until this important problem is fixed, using Android Studio is like using Windows Notepad to edit code!

A working project that reproduces this issue was uploaded to this issue on October 29th last year.   Can you please try the project and let us know the results?

Hi all, sorry for the frustration. The bug is in gradle plugin so in order to get it working, one has to update the android gradle plugin to version 3.3.1 specified in the PROJECT_ROOT/build.gradle file. Simply opening the project with Android Studio 3.3.1 would not solve the problem.

The problem still exists with plugin version 3.3.1 - I updated the example project gradle files and added some types and comments in the source code to make it more obvious. Please have a closer look at the issue. If you open native-lib.cpp, the external-lib.hpp header is found, but if you open external-lib.cpp, the external-lib.hpp header is NOT found, symbols in it are not resolved, and "go to definition" does not work (neither on the include directive itself nor on symbols from that header). Also note that "external-lib.hpp" shows up in "includes" in the Project/Android view under app/cpp/native-lib/includes but not under app/cpp/external-lib/includes. I think the root cause is still the same as described above, the relative include paths (in compiler flags) in android_gradle_build.json being interpreted as relative to CMAKE_CURRENT_BINARY_DIR (app/.externalNativeBuild/cmake/debug/arm64-v8a/external-lib) when they are relative to CMAKE_BINARY_DIR (app/.externalNativeBuild/cmake/debug/arm64-v8a).

Android Studio 3.5 Canary 4 seems to be actually fixing this, but 3.4 beta 4 and 3.3.1 not (or only partially) - tried all android studio versions with their matching android gradle plugin versions.

Hi Kai, thank you for the feedback! You are exactly right. The fix we have in 3.3.1 is a partial fix and the full fix will be in 3.3.2, which should resolve the problem manifested by the test project. Sorry for not have communicated this clear!