Fixed
Status Update
No update yet.
Comments
ve...@google.com
ve...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
cl...@gmail.com
ve...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ad...@google.com
ia...@google.com
This can end up getting triggered in a lot of ways. It looks like a variety of methods use the fromCursor method to construct the PreviewChannel. This creates a builder and tries to set all the values from the builder. Description is explicitly NOT required when constructing a PreviewChannel but once you've stored one in the database without a description, you get NPEs from no description:
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-master-dev:tv-provider/tv-provider/src/main/java/androidx/tvprovider/media/tv/PreviewChannel.java;l=98
This is especially painful because it makes most of the regular ways of getting a PreviewChannel broken. For example, just doing PreviewChannelHelper(context).allChannels is enough to throw the NPE.
This is especially painful because it makes most of the regular ways of getting a PreviewChannel broken. For example, just doing PreviewChannelHelper(context).allChannels is enough to throw the NPE.
ra...@google.com
Hi Adarsh,
I'm planning to work on the fix here.
Lemme know in case this is already is progress or has been fixed.
I'm planning to work on the fix here.
Lemme know in case this is already is progress or has been fixed.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6a15553ecd52c81df5bfa4cb37c65e409945122d
Author: Rahul Arora <raharora@google.com>
Date: Wed May 06 15:24:18 2020
Adds nullability annotations to PreviewChannel#setDescription
Bug: 119800858
Test: Modified PreviewChannelTest.java#testFullyPopulatedPreviewChannel() by setting description to null and ommitting assertEquals check for previewChannel#description.
./gradlew updateApi : Successful
./gradlew tvprovider:tvprovider:assemble : Successful
./gradlew createArchive : Successful
./gradlew buildOnServer : Successful
Change-Id: I1d399bdda9c003f54c51dbcbf7f15ea1a8713ba9
M tv-provider/tv-provider/api/1.1.0-alpha01.txt
M tv-provider/tv-provider/api/current.txt
M tv-provider/tv-provider/api/public_plus_experimental_1.1.0-alpha01.txt
M tv-provider/tv-provider/api/public_plus_experimental_current.txt
M tv-provider/tv-provider/api/restricted_1.1.0-alpha01.txt
M tv-provider/tv-provider/api/restricted_current.txt
M tv-provider/tv-provider/src/main/java/androidx/tvprovider/media/tv/PreviewChannel.java
https://android-review.googlesource.com/1304173
Branch: androidx-master-dev
commit 6a15553ecd52c81df5bfa4cb37c65e409945122d
Author: Rahul Arora <raharora@google.com>
Date: Wed May 06 15:24:18 2020
Adds nullability annotations to PreviewChannel#setDescription
Bug: 119800858
Test: Modified PreviewChannelTest.java#testFullyPopulatedPreviewChannel() by setting description to null and ommitting assertEquals check for previewChannel#description.
./gradlew updateApi : Successful
./gradlew tvprovider:tvprovider:assemble : Successful
./gradlew createArchive : Successful
./gradlew buildOnServer : Successful
Change-Id: I1d399bdda9c003f54c51dbcbf7f15ea1a8713ba9
M tv-provider/tv-provider/api/1.1.0-alpha01.txt
M tv-provider/tv-provider/api/current.txt
M tv-provider/tv-provider/api/public_plus_experimental_1.1.0-alpha01.txt
M tv-provider/tv-provider/api/public_plus_experimental_current.txt
M tv-provider/tv-provider/api/restricted_1.1.0-alpha01.txt
M tv-provider/tv-provider/api/restricted_current.txt
M tv-provider/tv-provider/src/main/java/androidx/tvprovider/media/tv/PreviewChannel.java
ra...@google.com
Raised another CL for handling the case where developer is using the same builder to populate different PreviewChannel Objects.
https://android-review.googlesource.com/c/platform/frameworks/support/+/1310577
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1eacea96a3d01613e229439bbe362a56f3368daf
Author: Rahul Arora <raharora@google.com>
Date: Wed May 13 21:26:15 2020
Setting PreviewChannel#description as empty for null cases
Bug : 119800858
This is an improvement over the previous CL which added the null check inside the description setter.
https://android-review.googlesource.com/c/platform/frameworks/support/+/1304173
Use Cases : If a developer is using the same builder to construct different PreviewChannel Objects by overriding different fields, then setting a null description might result in setting the description of the previous builder object's data in the current scenario.
Test: Unit-test imitating the above use case
./gradlew buildOnServer : Successful
Change-Id: I82e0b1250015b95b405180e7fd95f91d6e1e83c4
M tv-provider/tv-provider/src/androidTest/java/androidx/tvprovider/media/tv/PreviewChannelHelperTest.java
M tv-provider/tv-provider/src/main/java/androidx/tvprovider/media/tv/PreviewChannel.java
https://android-review.googlesource.com/1310577
Branch: androidx-master-dev
commit 1eacea96a3d01613e229439bbe362a56f3368daf
Author: Rahul Arora <raharora@google.com>
Date: Wed May 13 21:26:15 2020
Setting PreviewChannel#description as empty for null cases
Bug : 119800858
This is an improvement over the previous CL which added the null check inside the description setter.
Use Cases : If a developer is using the same builder to construct different PreviewChannel Objects by overriding different fields, then setting a null description might result in setting the description of the previous builder object's data in the current scenario.
Test: Unit-test imitating the above use case
./gradlew buildOnServer : Successful
Change-Id: I82e0b1250015b95b405180e7fd95f91d6e1e83c4
M tv-provider/tv-provider/src/androidTest/java/androidx/tvprovider/media/tv/PreviewChannelHelperTest.java
M tv-provider/tv-provider/src/main/java/androidx/tvprovider/media/tv/PreviewChannel.java
ra...@google.com
This was fixed and released as part of latest TV Provider release.
https://developer.android.com/jetpack/androidx/releases/tvprovider#1.1.0-alpha01
I'm resolving this ticket.
Feel free to re-open this in case of any issues.
I'm resolving this ticket.
Feel free to re-open this in case of any issues.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1eacea96a3d01613e229439bbe362a56f3368daf
Author: Rahul Arora <raharora@google.com>
Date: Wed May 13 21:26:15 2020
Setting PreviewChannel#description as empty for null cases
Bug : 119800858
This is an improvement over the previous CL which added the null check inside the description setter.
https://android-review.googlesource.com/c/platform/frameworks/support/+/1304173
Use Cases : If a developer is using the same builder to construct different PreviewChannel Objects by overriding different fields, then setting a null description might result in setting the description of the previous builder object's data in the current scenario.
Test: Unit-test imitating the above use case
./gradlew buildOnServer : Successful
Change-Id: I82e0b1250015b95b405180e7fd95f91d6e1e83c4
M tv-provider/tv-provider/src/androidTest/java/androidx/tvprovider/media/tv/PreviewChannelHelperTest.java
M tv-provider/tv-provider/src/main/java/androidx/tvprovider/media/tv/PreviewChannel.java
https://android-review.googlesource.com/1310577
Branch: androidx-master-dev
commit 1eacea96a3d01613e229439bbe362a56f3368daf
Author: Rahul Arora <raharora@google.com>
Date: Wed May 13 21:26:15 2020
Setting PreviewChannel#description as empty for null cases
Bug : 119800858
This is an improvement over the previous CL which added the null check inside the description setter.
Use Cases : If a developer is using the same builder to construct different PreviewChannel Objects by overriding different fields, then setting a null description might result in setting the description of the previous builder object's data in the current scenario.
Test: Unit-test imitating the above use case
./gradlew buildOnServer : Successful
Change-Id: I82e0b1250015b95b405180e7fd95f91d6e1e83c4
M tv-provider/tv-provider/src/androidTest/java/androidx/tvprovider/media/tv/PreviewChannelHelperTest.java
M tv-provider/tv-provider/src/main/java/androidx/tvprovider/media/tv/PreviewChannel.java
Description
Version used: 1.0.0
Theme used: None
Devices/Android versions reproduced on: Nvidia Shield running Android 8.
When trying to update an existing preview channel using PreviewChannelHelper from the above library a NullPointerException is thrown.
It seems that the description of the current channel is not set and when the helper tries to retain it and set it on the new channel it throw the exception.
Here it is:
java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.String java.lang.CharSequence.toString()' on a null object reference
at androidx.tvprovider.media.tv.PreviewChannel$Builder.setDescription(PreviewChannel.java:400)
at androidx.tvprovider.media.tv.PreviewChannel.fromCursor(PreviewChannel.java:98)
at androidx.tvprovider.media.tv.PreviewChannelHelper.getPreviewChannel(PreviewChannelHelper.java:209)
at androidx.tvprovider.media.tv.PreviewChannelHelper.updatePreviewChannel(PreviewChannelHelper.java:229)
at dk.youtec.drchannels.preview.BasePreviewUpdater.setupPreviewChannel(BasePreviewUpdater.kt:157)
at dk.youtec.drchannels.preview.BasePreviewUpdater.doWork(BasePreviewUpdater.kt:47)
at androidx.work.Worker$1.run(Worker.java:57)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
at java.lang.Thread.run(Thread.java:764)