Support suspend function in a non-abstract @Transaction DAO method. [120241587]

Fixed

Feature Request

Status Update

No update yet.

Description

da...@google.com

created issue #1

Nov 30, 2018 12:58AM

Consider supporting the following DAO method:

@Transaction
suspend fun insertBookAndAuthorSuspend(book: Book, author: Author) {
addBooks(book)
addAuthors(author)
}

Comments

ma...@marcardar.com <ma...@marcardar.com> #2Feb 10, 2019 07:38AM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

da...@google.com <da...@google.com> #3Feb 11, 2019 05:25PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ma...@marcardar.com <ma...@marcardar.com> #4Feb 12, 2019 02:43AM

deleted

da...@google.com <da...@google.com> #5Feb 12, 2019 06:13PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ed...@gmail.com <ed...@gmail.com> #6Feb 16, 2019 11:45AM

delete

ap...@google.com <ap...@google.com> #7Feb 26, 2019 11:08PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 633c84b26612914f9799d3dddfea5467afa36232
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Feb 11 17:13:04 2019

Support non-abstract @Transaction suspend DAO functions.

We can't support Rx, ListenableFutures or LiveData return types in
non-abstract @Transaction methods but we can support suspend methods by
utilizing the withTransactionContext API.

Bug: 120241587
Test: ./gradlew room:room-compiler:test \
room:integration-tests:room-testapp-kotlin:cC \
room:integration-tests:room-testapp:cC

Change-Id: I60c7115d375f688d1be17ea57e53e131b90957e5

M room/compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/compiler/src/main/kotlin/androidx/room/processor/MethodProcessorDelegate.kt
M room/compiler/src/main/kotlin/androidx/room/processor/TransactionMethodProcessor.kt
A room/compiler/src/main/kotlin/androidx/room/solver/transaction/binder/CoroutineTransactionMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/transaction/binder/InstantTransactionMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/transaction/binder/TransactionMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/transaction/result/TransactionMethodAdapter.kt
M room/compiler/src/main/kotlin/androidx/room/vo/TransactionMethod.kt
M room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M room/compiler/src/test/data/daoWriter/output/ComplexDao.java
M room/compiler/src/test/kotlin/androidx/room/processor/TransactionMethodProcessorTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/AbstractDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/BooksDaoTest.kt

https://android-review.googlesource.com/900657

https://goto.google.com/android-sha1/633c84b26612914f9799d3dddfea5467afa36232

da...@google.com <da...@google.com> Feb 26, 2019 11:10PM

Marked as fixed.