Fixed
Status Update
Comments
uc...@google.com <uc...@google.com> #2
These changes would be really nice! Being able to change the text colour is really important as it now doesn't match the rest of our app either.
Stack overflow posting -http://stackoverflow.com/questions/32533069/how-to-change-a-title-color-in-chrome-custom-tabs
Stack overflow posting -
de...@googlemail.com <de...@googlemail.com> #3
Changing text color and the overflow icon color is important to us too! Awesome work on the feature though.
lf...@google.com <lf...@google.com> #4
The ability of customize the status bar color is very important!
sa...@gmail.com <sa...@gmail.com> #5
It is in the essence of a "custom" UI component to have a custom color. Please add this feature!
lf...@google.com <lf...@google.com> #6
I have noted that the status bar automatically generated from the toolbar color is a bit darker than needed. The status bar color of the chrome activity is different to the one of the rest of my app. It doesn't strictly follow Material guidelines.
ak...@gmail.com <ak...@gmail.com> #7
The same issue I met. And is there a way to customize the title? using my own title rather than the url's. Thanks
lf...@google.com <lf...@google.com> #8
Would very appreciate this enhancement!
ak...@gmail.com <ak...@gmail.com> #9
I'd love to have the possibility to change title text color, I'll be a very important graphic consistency inside my app
ak...@gmail.com <ak...@gmail.com> #10
Voting +1 for this feature.
lf...@google.com <lf...@google.com> #11
It has been more than a year. Please add this!
lf...@google.com <lf...@google.com> #12
[Comment deleted]
ak...@gmail.com <ak...@gmail.com> #13
It will certainly be a nice feature and have a nice title for the chrome tab. Please fix this.
lf...@google.com <lf...@google.com> #14
Customize the status bar color is a real need. Voting +1
ak...@gmail.com <ak...@gmail.com> #15
Yes, it's needed definitely. Please!! Voting+1.
lf...@google.com <lf...@google.com> #16
Any date to the release of this feature? Working with VectorDrawables is awesome and let us have an IconKit but this little impediment make it not perfect
lf...@google.com <lf...@google.com> #17
Voting +1 for this feature.
ap...@google.com <ap...@google.com> #18
Voting +1 for this feature.
ap...@google.com <ap...@google.com> #19
voting +1 for this feature
lf...@google.com <lf...@google.com>
lf...@google.com <lf...@google.com> #20
Voting +1 for this feature.
ur...@gmail.com <ur...@gmail.com> #21
Voting +1 for this feature.
lf...@google.com <lf...@google.com> #22
+1 from me. I really need this feature.
ma...@gmail.com <ma...@gmail.com> #23
+1 from me. I've to fallback my implementation to webview because of this graphic inconsistency.
sa...@gmail.com <sa...@gmail.com> #24
Voting +1 for this feature.
lf...@google.com <lf...@google.com> #25
Voting +1 for this feature.
ma...@gmail.com <ma...@gmail.com> #26
Voting +1 for this feature.
lf...@google.com <lf...@google.com> #27
Not being able to set a proper dark or light statusbar/toolbar icon color is breaking our app color design very bad.
+1 for this feature.
+1 for this feature.
ma...@gmail.com <ma...@gmail.com> #28
Voting +1 for this feature.
lf...@google.com <lf...@google.com> #29
Estoy de acuerdo con este comentario, es molesto cuando el diseñador te levanta la mano porque no le convence el contraste de los colores y te es imposible responder con fundamento y suplir los criterios. Sería genial poder personalizar más esta sección.
ma...@gmail.com <ma...@gmail.com> #30
This has been an issue for 6 years now. Why isn't Google dealing with it? If I'm to use Custom Tabs, I need to be able to change the toolbar text and color at will.
na...@gmail.com <na...@gmail.com> #31
ช่วยแก้ไข browser ให้ผมหน่อยครับ
yo...@gmail.com <yo...@gmail.com> #32
Same issue on Macbook Pro 13" 2017 with emulator 28.0.20. Previous versions, no problem.
lf...@google.com <lf...@google.com> #33
#31, #32: Please try the emulator canary 28.0.21 and report if it makes a difference.
na...@gmail.com <na...@gmail.com> #34
My machine just crashed twice with 28.0.21. I'm not seeing much of a pattern. It's both worked and not worked with .20 and .21
I would keep testing, but I'm not very keen on kernel panics. I would be willing to do it a couple of time if there are some sort of error logs we could send.
I would keep testing, but I'm not very keen on kernel panics. I would be willing to do it a couple of time if there are some sort of error logs we could send.
lf...@google.com <lf...@google.com> #35
#34 Are you getting any kind of kernel panic log as in comment #7 ?
lf...@google.com <lf...@google.com> #36
Everyone who can reproduce this problem: Try out the linked emulator by running from the command line and piping all output to a file:
https://drive.google.com/open?id=1pHXfTX-1m16gO9MVPTAWWHJ4suLlFzsj
objs-mac-debug-log/emulator -avd <avdname> &> log.txt
and post the log.
objs-mac-debug-log/emulator -avd <avdname> &> log.txt
and post the log.
na...@gmail.com <na...@gmail.com> #38
Here are logs from my previous crashes. They are not the same format as the logs in #7. I grabbed them from /Library/Logs/DiagnosticReports/ProxiedDevice-Bridge.
I'll try the emulator from #37 today.
I'll try the emulator from #37 today.
na...@gmail.com <na...@gmail.com> #39
Crashed again with the build with lightweight logs. They don't seem to have much, but here you go. I'll try the emulator from #36 now.
na...@gmail.com <na...@gmail.com> #40
Here's a log from when it crashed with the emulator from #36
lf...@google.com <lf...@google.com> #41
Thanks very much for the logs! Although they are different, it's still essentially in the Intel driver.
We might have a fix that tries to avoid that code path in Apple's Intel GPU driver.
Try the emulator at this link:
https://drive.google.com/open?id=1z46V3UdtXEZgXBEGF6Lf2OLb_3n7jUdY
We might have a fix that tries to avoid that code path in Apple's Intel GPU driver.
Try the emulator at this link:
lf...@google.com <lf...@google.com> #42
#39, #40: I have since found a consistent repro: V1 Pro graphics benchmark; start it up, and while loading, quickboot save the emulator. Thus, I also found that piping it to the log may not be of much help as on a kernel panic, the log is still buffered and it gets cut off. One may have to film the monitor for the correct error log.
ap...@google.com <ap...@google.com> #44
Project: platform/external/qemu
Branch: emu-master-dev
commit 6286c8ca1fd2fe7d264500522c1b18a63effba2e
Author: Lingfeng Yang <lfy@google.com>
Date: Thu Dec 20 08:46:02 2018
[snapshot][gl] Always read some formats with glReadPixels
bug: 120951634
This CL makes texture images with the following setup:
- GL_TEXTURE_2D
- level 0
- GL_RGB(A)
- GL_UNSIGNED_BYTE
to be read with glReadPixels.
This is meant to work around a macOS kernel panic.
Test: V1 Benchmark Pro texture save does not cause kernel panic on Mac
Test: Snapshot save works correctly in home screen, chrome, antutu,
youtube
Change-Id: Ib42ec810ae15933aa307923040bd88aa0017d336
M android/android-emugl/host/include/OpenGLESDispatch/gles2_extensions_functions.h
M android/android-emugl/host/libs/Translator/EGL/EglImp.cpp
M android/android-emugl/host/libs/Translator/GLES_CM/GLEScmImp.cpp
M android/android-emugl/host/libs/Translator/GLES_V2/GLESv2Imp.cpp
M android/android-emugl/host/libs/Translator/GLcommon/SaveableTexture.cpp
M android/android-emugl/host/libs/Translator/include/GLcommon/SaveableTexture.h
M android/android-emugl/host/libs/Translator/include/GLcommon/TranslatorIfaces.h
M android/android-emugl/host/libs/libOpenGLESDispatch/gles2_extensions.entries
M android/third_party/tinyepoxy/tinyepoxy.cpp
https://android-review.googlesource.com/856470
https://goto.google.com/android-sha1/6286c8ca1fd2fe7d264500522c1b18a63effba2e
Branch: emu-master-dev
commit 6286c8ca1fd2fe7d264500522c1b18a63effba2e
Author: Lingfeng Yang <lfy@google.com>
Date: Thu Dec 20 08:46:02 2018
[snapshot][gl] Always read some formats with glReadPixels
bug: 120951634
This CL makes texture images with the following setup:
- GL_TEXTURE_2D
- level 0
- GL_RGB(A)
- GL_UNSIGNED_BYTE
to be read with glReadPixels.
This is meant to work around a macOS kernel panic.
Test: V1 Benchmark Pro texture save does not cause kernel panic on Mac
Test: Snapshot save works correctly in home screen, chrome, antutu,
youtube
Change-Id: Ib42ec810ae15933aa307923040bd88aa0017d336
M android/android-emugl/host/include/OpenGLESDispatch/gles2_extensions_functions.h
M android/android-emugl/host/libs/Translator/EGL/EglImp.cpp
M android/android-emugl/host/libs/Translator/GLES_CM/GLEScmImp.cpp
M android/android-emugl/host/libs/Translator/GLES_V2/GLESv2Imp.cpp
M android/android-emugl/host/libs/Translator/GLcommon/SaveableTexture.cpp
M android/android-emugl/host/libs/Translator/include/GLcommon/SaveableTexture.h
M android/android-emugl/host/libs/Translator/include/GLcommon/TranslatorIfaces.h
M android/android-emugl/host/libs/libOpenGLESDispatch/gles2_extensions.entries
M android/third_party/tinyepoxy/tinyepoxy.cpp
ap...@google.com <ap...@google.com> #45
Project: platform/external/qemu
Branch: emu-3.0-release
commit 37caaa4390da7431248dce42e06391634e70efb9
Author: Lingfeng Yang <lfy@google.com>
Date: Thu Dec 20 08:46:02 2018
[snapshot][gl] Always read some formats with glReadPixels
bug: 120951634
This CL makes texture images with the following setup:
- GL_TEXTURE_2D
- level 0
- GL_RGB(A)
- GL_UNSIGNED_BYTE
to be read with glReadPixels.
This is meant to work around a macOS kernel panic.
Test: V1 Benchmark Pro texture save does not cause kernel panic on Mac
Test: Snapshot save works correctly in home screen, chrome, antutu,
youtube
Change-Id: Ib42ec810ae15933aa307923040bd88aa0017d336
(cherry picked from commit 6286c8ca1fd2fe7d264500522c1b18a63effba2e)
M android/android-emugl/host/include/OpenGLESDispatch/gles2_extensions_functions.h
M android/android-emugl/host/libs/Translator/EGL/EglImp.cpp
M android/android-emugl/host/libs/Translator/GLES_CM/GLEScmImp.cpp
M android/android-emugl/host/libs/Translator/GLES_V2/GLESv2Imp.cpp
M android/android-emugl/host/libs/Translator/GLcommon/SaveableTexture.cpp
M android/android-emugl/host/libs/Translator/include/GLcommon/SaveableTexture.h
M android/android-emugl/host/libs/Translator/include/GLcommon/TranslatorIfaces.h
M android/android-emugl/host/libs/libOpenGLESDispatch/gles2_extensions.entries
M android/third_party/tinyepoxy/tinyepoxy.cpp
https://android-review.googlesource.com/856472
https://goto.google.com/android-sha1/37caaa4390da7431248dce42e06391634e70efb9
Branch: emu-3.0-release
commit 37caaa4390da7431248dce42e06391634e70efb9
Author: Lingfeng Yang <lfy@google.com>
Date: Thu Dec 20 08:46:02 2018
[snapshot][gl] Always read some formats with glReadPixels
bug: 120951634
This CL makes texture images with the following setup:
- GL_TEXTURE_2D
- level 0
- GL_RGB(A)
- GL_UNSIGNED_BYTE
to be read with glReadPixels.
This is meant to work around a macOS kernel panic.
Test: V1 Benchmark Pro texture save does not cause kernel panic on Mac
Test: Snapshot save works correctly in home screen, chrome, antutu,
youtube
Change-Id: Ib42ec810ae15933aa307923040bd88aa0017d336
(cherry picked from commit 6286c8ca1fd2fe7d264500522c1b18a63effba2e)
M android/android-emugl/host/include/OpenGLESDispatch/gles2_extensions_functions.h
M android/android-emugl/host/libs/Translator/EGL/EglImp.cpp
M android/android-emugl/host/libs/Translator/GLES_CM/GLEScmImp.cpp
M android/android-emugl/host/libs/Translator/GLES_V2/GLESv2Imp.cpp
M android/android-emugl/host/libs/Translator/GLcommon/SaveableTexture.cpp
M android/android-emugl/host/libs/Translator/include/GLcommon/SaveableTexture.h
M android/android-emugl/host/libs/Translator/include/GLcommon/TranslatorIfaces.h
M android/android-emugl/host/libs/libOpenGLESDispatch/gles2_extensions.entries
M android/third_party/tinyepoxy/tinyepoxy.cpp
na...@gmail.com <na...@gmail.com> #46
I've successfully exited the emulator in #43 without issue, several times. I'll keep testing with that build. The fix looks promising!
lf...@google.com <lf...@google.com> #47
Glad it's working! We've now released it more widely as 28.0.22 canary.
ar...@gmail.com <ar...@gmail.com> #50
Mi A2
ap...@google.com <ap...@google.com> #51
Project: platform/external/qemu
Branch: emu-3.1-release
commit 5d76ed5de6661eaa0e1836f67ea46d5afc115599
Author: Lingfeng Yang <lfy@google.com>
Date: Thu Dec 20 08:46:02 2018
[snapshot][gl] Always read some formats with glReadPixels
bug: 120951634
This CL makes texture images with the following setup:
- GL_TEXTURE_2D
- level 0
- GL_RGB(A)
- GL_UNSIGNED_BYTE
to be read with glReadPixels.
This is meant to work around a macOS kernel panic.
Test: V1 Benchmark Pro texture save does not cause kernel panic on Mac
Test: Snapshot save works correctly in home screen, chrome, antutu,
youtube
Change-Id: Ib42ec810ae15933aa307923040bd88aa0017d336
(cherry picked from commit 6286c8ca1fd2fe7d264500522c1b18a63effba2e)
M android/android-emugl/host/include/OpenGLESDispatch/gles2_extensions_functions.h
M android/android-emugl/host/libs/Translator/EGL/EglImp.cpp
M android/android-emugl/host/libs/Translator/GLES_CM/GLEScmImp.cpp
M android/android-emugl/host/libs/Translator/GLES_V2/GLESv2Imp.cpp
M android/android-emugl/host/libs/Translator/GLcommon/SaveableTexture.cpp
M android/android-emugl/host/libs/Translator/include/GLcommon/SaveableTexture.h
M android/android-emugl/host/libs/Translator/include/GLcommon/TranslatorIfaces.h
M android/android-emugl/host/libs/libOpenGLESDispatch/gles2_extensions.entries
M android/third_party/tinyepoxy/tinyepoxy.cpp
https://android-review.googlesource.com/917019
https://goto.google.com/android-sha1/5d76ed5de6661eaa0e1836f67ea46d5afc115599
Branch: emu-3.1-release
commit 5d76ed5de6661eaa0e1836f67ea46d5afc115599
Author: Lingfeng Yang <lfy@google.com>
Date: Thu Dec 20 08:46:02 2018
[snapshot][gl] Always read some formats with glReadPixels
bug: 120951634
This CL makes texture images with the following setup:
- GL_TEXTURE_2D
- level 0
- GL_RGB(A)
- GL_UNSIGNED_BYTE
to be read with glReadPixels.
This is meant to work around a macOS kernel panic.
Test: V1 Benchmark Pro texture save does not cause kernel panic on Mac
Test: Snapshot save works correctly in home screen, chrome, antutu,
youtube
Change-Id: Ib42ec810ae15933aa307923040bd88aa0017d336
(cherry picked from commit 6286c8ca1fd2fe7d264500522c1b18a63effba2e)
M android/android-emugl/host/include/OpenGLESDispatch/gles2_extensions_functions.h
M android/android-emugl/host/libs/Translator/EGL/EglImp.cpp
M android/android-emugl/host/libs/Translator/GLES_CM/GLEScmImp.cpp
M android/android-emugl/host/libs/Translator/GLES_V2/GLESv2Imp.cpp
M android/android-emugl/host/libs/Translator/GLcommon/SaveableTexture.cpp
M android/android-emugl/host/libs/Translator/include/GLcommon/SaveableTexture.h
M android/android-emugl/host/libs/Translator/include/GLcommon/TranslatorIfaces.h
M android/android-emugl/host/libs/libOpenGLESDispatch/gles2_extensions.entries
M android/third_party/tinyepoxy/tinyepoxy.cpp
ap...@google.com <ap...@google.com> #52
Project: platform/external/qemu
Branch: emu-3.1-release
commit 0b7f6cad73163e70d65d9e6ac727e47642d0e98d
Author: Lingfeng Yang <lfy@google.com>
Date: Fri Dec 14 09:07:53 2018
[snapshot] Eagerly tear down RAM mappings on exit
bug: 120951634
Some users are experiencing kernel panic on snapshot save with
file-backed RAM when -gpu host is also enabled; the graphics driver
seems to cause a page fault in the kernel when saving on exit.
Speculative fix: Eagerly tear down RAM mappings.
+ a subtlety: Don't run ram block removal notifiers when exiting;
it's possible they were registered to a virtual device that has also
been torn down, possibly segfaulting in user space.
Change-Id: Iee1567dac2c997f1c89a573cb2e5a7369a1399ad
(cherry picked from commit 6241395508b6c846566fd423d83cd5ec607590ab)
M exec.c
M hw/i386/pc.c
M hw/i386/pc_piix.c
M include/exec/memory.h
M include/exec/ram_addr.h
M include/hw/boards.h
M include/hw/i386/pc.h
M memory.c
M vl.c
https://android-review.googlesource.com/917017
https://goto.google.com/android-sha1/0b7f6cad73163e70d65d9e6ac727e47642d0e98d
Branch: emu-3.1-release
commit 0b7f6cad73163e70d65d9e6ac727e47642d0e98d
Author: Lingfeng Yang <lfy@google.com>
Date: Fri Dec 14 09:07:53 2018
[snapshot] Eagerly tear down RAM mappings on exit
bug: 120951634
Some users are experiencing kernel panic on snapshot save with
file-backed RAM when -gpu host is also enabled; the graphics driver
seems to cause a page fault in the kernel when saving on exit.
Speculative fix: Eagerly tear down RAM mappings.
+ a subtlety: Don't run ram block removal notifiers when exiting;
it's possible they were registered to a virtual device that has also
been torn down, possibly segfaulting in user space.
Change-Id: Iee1567dac2c997f1c89a573cb2e5a7369a1399ad
(cherry picked from commit 6241395508b6c846566fd423d83cd5ec607590ab)
M exec.c
M hw/i386/pc.c
M hw/i386/pc_piix.c
M include/exec/memory.h
M include/exec/ram_addr.h
M include/hw/boards.h
M include/hw/i386/pc.h
M memory.c
M vl.c
fo...@gmail.com <fo...@gmail.com> #53
Chibai Chineses name
bs...@gmail.com <bs...@gmail.com> #54
K
Description
AI-181.5540.7.32.5056338, JRE 1.8.0_152-release-1136-b06x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.14.1 unknown, screens 1440x900
Android Gradle Plugin: 3.2.1
Gradle: 4.6
NDK: from local.properties: 18.1.5063045; latest from SDK: 18.1.5063045;
LLDB: pinned revision 3.1 not found; latest from SDK: (package not found);
CMake: from local.properties: (not specified); latest from SDK: (not found); from PATH: (not found);
IMPORTANT: Please read