Fixed
Status Update
No update yet.
Comments
mi...@sherpany.com
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
fi...@gmail.com
yea i'll take it.
il...@google.com
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
il...@google.com
ap...@google.com
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
ap...@google.com
With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)
jb...@google.com
yea sorry immediate does not fix it.
I actually have a WIP fix for it:
https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186
if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}
I actually have a WIP fix for it:
if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}
Description
Version used: 28 (same on 1.0.0)
Devices/Android versions reproduced on: 8.0
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
attached sample project:
on app start you can see animation on child fragment enter (slide down)
with pressing "back" you can see correct exit animation (slide up)
with pressing button on center of screen you can observe error -> fragment should disappear but enter animation is played
RCA: (as far as I investigated that)
971 -> here child FragmentManager try to load animation for fragment but fragment.getNextAnim() still return "last" animation which is enter -> it should be updated to exit animation before -> in this place fragment manager know that it's removing fragment