Fixed
Status Update
No update yet.
Comments
yb...@google.com
I created a thread on the android-developers forum related to this bug:
http://groups.google.com/group/android-
developers/browse_thread/thread/6caa57135927e242/86d4d895e88a5ebb?
lnk=gst&q=custom+account#86d4d895e88a5ebb
developers/browse_thread/thread/6caa57135927e242/86d4d895e88a5ebb?
lnk=gst&q=custom+account#86d4d895e88a5ebb
wo...@gmail.com
My personal theory is that Google broke this part of the API intentionally to keep
the lock-in on sync functionality they've enjoyed since Android 1.0.....
the lock-in on sync functionality they've enjoyed since Android 1.0.....
yb...@google.com
[Comment deleted]
ya...@gmail.com
ya...@gmail.com
ExternalSource.java bug
protected void inflate(Context context, XmlPullParser parser)
{
final AttributeSet attrs = Xml.asAttributeSet(parser); << It can't read any
attributes from the ContactsDataKind tag. It should located blow the second while
loop.
try
{
int type;
while((type = parser.next()) != XmlPullParser.START_TAG &&
type != XmlPullParser.END_DOCUMENT)
{
// Drain comments and whitespace
}
if(type != XmlPullParser.START_TAG)
{
throw new IllegalStateException("No start tag found");
}
if(!InflateTags.CONTACTS_SOURCE.equals(parser.getName()))
{
throw new IllegalStateException("Top level element must be " +
InflateTags.CONTACTS_SOURCE);
}
protected void inflate(Context context, XmlPullParser parser)
{
final AttributeSet attrs = Xml.asAttributeSet(parser); << It can't read any
attributes from the ContactsDataKind tag. It should located blow the second while
loop.
try
{
int type;
while((type = parser.next()) != XmlPullParser.START_TAG &&
type != XmlPullParser.END_DOCUMENT)
{
// Drain comments and whitespace
}
if(type != XmlPullParser.START_TAG)
{
throw new IllegalStateException("No start tag found");
}
if(!InflateTags.CONTACTS_SOURCE.equals(parser.getName()))
{
throw new IllegalStateException("Top level element must be " +
InflateTags.CONTACTS_SOURCE);
}
ap...@google.com
Any feedback from Google guys?
It doesn't seem to be fixed in Android 2.2 and actually is going to be a blocking issue for third party sync providers. We cannot claim to sync contacts if the user cannot edit them.
Looking at the code, the fix is very easy (at least to let sync providers to use the same contact structure used by Google accounts).
Please let us know if and when you can work on this.
It doesn't seem to be fixed in Android 2.2 and actually is going to be a blocking issue for third party sync providers. We cannot claim to sync contacts if the user cannot edit them.
Looking at the code, the fix is very easy (at least to let sync providers to use the same contact structure used by Google accounts).
Please let us know if and when you can work on this.
ma...@gmail.com
Could anyone give an answer please?
In Android SDK 2.2 you added a beautiful example about how to create a Contacts Sync Adapter:
http://developer.android.com/resources/samples/SampleSyncAdapter/index.html
BTW if you see the sync adapter definition you realize that it doesn't support uploading, it means that all the contacts are not editable (the same as in Facebook accounts), is it casual???
Why did you do such a huge work, if you still have this kind of bugs?? I'm really start thinking the same as in comment 2.
In Android SDK 2.2 you added a beautiful example about how to create a Contacts Sync Adapter:
BTW if you see the sync adapter definition you realize that it doesn't support uploading, it means that all the contacts are not editable (the same as in Facebook accounts), is it casual???
Why did you do such a huge work, if you still have this kind of bugs?? I'm really start thinking the same as in comment 2.
Description
These converters of cause need an instance of moshi.
It would be great if you could let the room builder take converters so one can properly inject the converters dependencies.
Right now the "hack" that you see on many stackoverflow posts is that people use a static reference to the dagger component.
The api could look like this:
@Provides
@JvmStatic
@Singleton
fun provideAppDb(context: Context, migrations: List<@JvmSuppressWildcards Migration>, xConverter : XConverter): AppDb {
return Room.databaseBuilder(context, AppDb::class.java, "repo")
.addMigrations(*migrations.toTypedArray())
.addConverter(xConverter)
.build()
}