Androidx BiometricPrompt Cancel button Crashes [122054485]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ch...@gmail.com

created issue #1

Dec 27, 2018 10:17PM

Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): androidx.biometric:biometric:1.0.0-alpha03
Version used:1.0.0-alpha03
Theme used:Theme.MaterialComponents.Light.NoActionBar"
Devices/Android versions reproduced on:
- Galaxy S9+/8.0.0
- Emulator/9.0.0

- Relevant code to trigger the issue.

override fun onResume() {
super.onResume()

DataManager.instance.getBiometricCredential(this)?.let {
BiometricUtils.authenticateBiometric(this,
object : BiometricPrompt.AuthenticationCallback() {

override fun onAuthenticationError(errorCode: Int,
errString: CharSequence) {
Log.d(TAG,
"onAuthenticationError - errorCode: $errorCode, errorString: $errString")
if(errorCode != BiometricPrompt.ERROR_CANCELED) {

bus.post(ShowMessageEvent(R.string.error_title,
R.string.unable_to_verify_fingerprint,
null,
null,
R.string.dismiss,
null,
null,
{ dialog -> dialog.dismiss() },
true))
}

override fun onAuthenticationSucceeded(result: BiometricPrompt.AuthenticationResult) {

val user = DataManager.instance.getBiometricCredential(
context)

Log.d(TAG,
"onAuthenticationSucceeded - logging in biometric user: ${user?.id
?: ""}")

user?.let {
binding.textEmail.setText(user.username)
binding.textPassword.setText(user.password)
signIn()
} ?: run {

bus.post(ShowMessageEvent(R.string.error_title,
R.string.error_general_error_message,
null,
null,
R.string.dismiss,
null,
null,
{ dialog -> dialog.dismiss() },
true))
}
}

})
}
}

fun authenticateBiometric(activity: FragmentActivity,
callback: BiometricPrompt.AuthenticationCallback) {
var signature: Signature? = null

try {

KeyStoreUtil.getKeyPair(KeyStoreUtil.BIOMETRIC)?.let {

signature = Signature.getInstance("SHA256withECDSA")
signature?.initSign(it.private)
}
} catch (e: Exception) {
}

val promptInfo = BiometricPrompt.PromptInfo.Builder()
.setTitle(stringProvider.getString(R.string.fingerprint_login))
.setDescription("")
.setNegativeButtonText(stringProvider.getString(R.string.cancel))
.build()

signature?.let {
BiometricPrompt(activity, TaskExecutors.MAIN_THREAD, callback).authenticate(promptInfo,
BiometricPrompt.CryptoObject(
it))
}
}

Pressing cancel on the BiometricDialog produces the following exception:

2018-12-27 15:14:00.933 5960-5960/

com.smartrent.resident.qa E/AndroidRuntime: FATAL EXCEPTION: main
Process:

com.smartrent.resident.qa, PID: 5960
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.CharSequence androidx.biometric.FingerprintDialogFragment.getNegativeButtonText()' on a null object reference
at androidx.biometric.BiometricPrompt$1$1.run(BiometricPrompt.java:336)
at android.os.Handler.handleCallback(Handler.java:789)
at android.os.Handler.dispatchMessage(Handler.java:98)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6938)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

Comments

ku...@google.com <ku...@google.com> Dec 28, 2018 05:37AM

Assigned to ku...@google.com.

ku...@google.com <ku...@google.com> #2Dec 28, 2018 09:43AM

Project: platform/frameworks/support
Branch: androidx-main

commit c46d3e79b2ea8b839358f0215b0a432ef8fad7a2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:23:25 2022

Convert androidx.activity.Cancellable to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Change-Id: I057f3e54811e7399e40083ef5e3915adc4fa425d

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288554

ch...@gmail.com <ch...@gmail.com> #3Dec 28, 2018 04:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7fd8a3206a49baefee8340f0839fcd4de7716788
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:13:23 2022

Rename androidx.activity.Cancellable from .java to .kt

Test: n/a
Bug:257291701
Change-Id: I7f2ff8ce79af41c6437fb9a0f1be90e8990495e8

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288553

bugreport-2018-12-28-08-16-45-dumpstate_log-14038.txt

6.3 KB

View

Download

bugreport-2018-12-28-08-16-45.zip

8.3 MB

Download

dumpstate-stats.txt

7 B

View

Download

BrokenBiometric.zip

25 MB

Download

ch...@gmail.com <ch...@gmail.com> #4Dec 28, 2018 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4d21e0a45f19ed238ef30756f576930af07449c2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:25:08 2022

Convert ActivityResultCallback to kotlin

Including clean up in test usages of this interface

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: Converted ActvitiyResultCallback to kotlin. Maintains source and binary comptability.
Change-Id: Ifc5e5e1a9a7ed4e281007830fb8d4c74237c63ce

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288334

ku...@google.com <ku...@google.com> #5Dec 31, 2018 08:38AM

Project: platform/frameworks/support
Branch: androidx-main

commit ae5bcbc9174b9767f143bfd9629a69fcd3ed325d
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:06:36 2022

Rename ActivityResultCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I43a8c76cb51e3eee4a1ec2cb6f0128753d85965d

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288333

Video_sailfish-PQ1A.181205.002.mp4

22 MB

Download

ja...@gmail.com <ja...@gmail.com> #6Jan 2, 2019 08:38AM

Project: platform/frameworks/support
Branch: androidx-main

commit 91f60f5adb619fc0a2ddc866c94670a2f046799a
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 16:59:43 2022

Convert OnBackPressedCallback to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: OnBackPressedCallback is now in Kotlin
Change-Id: Ide1b056e438b403c9b1888bc7dfedf283f1ff168

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288079

bugreport-2019-01-02-09-33-10.zip

4 MB

Download

ja...@gmail.com <ja...@gmail.com> #7Jan 2, 2019 08:43AM

Project: platform/frameworks/support
Branch: androidx-main

commit 324a9ebeb0c23ca0113a925c83a4b90a74c7dc54
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:57:01 2022

Rename OnBackPressedCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I3645ebd21c0ea9c243fad3007bdd3d2472806dcc

M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288078

bugreport-blueline-PQ1A.181205.006-2019-01-02-09-40-36.zip

3.6 MB

Download

ku...@google.com <ku...@google.com> Jan 22, 2019 09:29AM

Reassigned to kc...@google.com.

ma...@gmail.com <ma...@gmail.com> #8Jan 22, 2019 11:46AM

Project: platform/frameworks/support
Branch: androidx-main

commit a6ec8cc8df1fd6e8a4407ad15569d77914e9adb3
Author: Ian Lake <ilake@google.com>
Date: Wed Jan 25 00:05:20 2023

Move OnBackPressedDispatcher extension to main artifact

As the main activity artifact is automatically included
whenever a developer depends on activity-ktx and these are
in an atomic library group, we can move the Kotlin
extension from activity-ktx to activity itself now that
the class itself has been moved to Kotlin.

Relnote: n/a
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: I13482de2e25bd6e084f4b299dddd43b2bcf7a4c7

A activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/public_plus_experimental_current.txt
A activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/src/androidTest/java/androidx/activity/OnBackPressedDispatcherTest.kt
D activity/activity-ktx/src/main/java/androidx/activity/OnBackPressedDispatcher.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/OnBackPressedDispatcherTest.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401943

kc...@google.com <kc...@google.com> #9Jan 22, 2019 11:05PM

Reassigned to jo...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit d54d4417476c5ddc37251a910bdf37e9d278357e
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:57:45 2023

Replace usages of Consumer with a lambda

Now that OnBackPressedCallback and
OnBackPressedDispatcher are both written in Kotlin,
we can convert the callback between the two to be a
lambda method, rather than using a Consumer<Boolean>.

Test: tests still pass
BUG: 257291701
Change-Id: I0e2e4a3e7e9d6a3aeab1b8d2283fff321d45f44f

M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401942

ap...@google.com <ap...@google.com> #10Jan 24, 2019 08:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit 453e6f7acd7b7a1310487fc912f78c0fd2e72dd3
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:43:12 2023

Convert OnBackPressedDispatcher to Kotlin

Relnote: "`OnBackPressedDispatcher` is now written in Kotlin."
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: I18ac79d3cd20fc29159542b729935d3b8d2e4506

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401941

jo...@google.com <jo...@google.com> Jan 25, 2019 12:30AM

Marked as fixed.

ch...@gmail.com <ch...@gmail.com> #11Feb 11, 2019 06:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 57dd231f03ef3f5d107f7c9be9b0f5dd200d7ec4
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:01:48 2023

Rename OnBackPressedDispatcher.java to .kt

Test: n/a
BUG: 257291701
Change-Id: Id490de8b28b7d2a680c76c822f564fdadd5eb5f1

M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401940

ph...@gmail.com <ph...@gmail.com> #12Apr 4, 2019 04:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 76fcc8653339d275c9bfad10e4c68cd9c8ef0dfd
Author: Ian Lake <ilake@google.com>
Date: Fri Jan 27 00:45:07 2023

Update wear module with OnBackPressedDispatcherOwner

With the move of OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: Iaf4f466f38a23c5522de019d38080b04c9f7b7ff

M wear/compose/compose-navigation/build.gradle
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt

https://android-review.googlesource.com/2405513

ph...@gmail.com <ph...@gmail.com> #13Apr 4, 2019 05:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit a63f1351aab5e387a829711f14de221274119bcd
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 22:51:46 2023

Update navigation module with OnBackPressedDispatcherOwner

With the move of OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: Iad795301ff2e6a16b42be6b85e6370ac399e43fd

M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt

https://android-review.googlesource.com/2404345

ph...@gmail.com <ph...@gmail.com> #14Apr 4, 2019 05:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit fa9a4dd728bc575c6e3536f2d5f9564f50b8eeee
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 19:33:26 2023

Update compose module with OnBackPressedDispatcherOwner

With the move to OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: If45fa4c4624a0a71745f4f11f133a3eddcf4dddf

M compose/ui/ui-tooling/build.gradle
M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/ComposeViewAdapter.kt

https://android-review.googlesource.com/2404338

Issue 122054485

Description

Issue summary

Comments

ku...@google.com <ku...@google.com> Dec 28, 2018 05:37AM

ku...@google.com <ku...@google.com> #2Dec 28, 2018 09:43AM

ch...@gmail.com <ch...@gmail.com> #3Dec 28, 2018 04:53PM

ch...@gmail.com <ch...@gmail.com> #4Dec 28, 2018 05:16PM

ku...@google.com <ku...@google.com> #5Dec 31, 2018 08:38AM

ja...@gmail.com <ja...@gmail.com> #6Jan 2, 2019 08:38AM

ja...@gmail.com <ja...@gmail.com> #7Jan 2, 2019 08:43AM

ku...@google.com <ku...@google.com> Jan 22, 2019 09:29AM

ma...@gmail.com <ma...@gmail.com> #8Jan 22, 2019 11:46AM

kc...@google.com <kc...@google.com> #9Jan 22, 2019 11:05PM

ap...@google.com <ap...@google.com> #10Jan 24, 2019 08:23PM

jo...@google.com <jo...@google.com> Jan 25, 2019 12:30AM

ch...@gmail.com <ch...@gmail.com> #11Feb 11, 2019 06:56PM

ph...@gmail.com <ph...@gmail.com> #12Apr 4, 2019 04:29PM

ph...@gmail.com <ph...@gmail.com> #13Apr 4, 2019 05:17PM

ph...@gmail.com <ph...@gmail.com> #14Apr 4, 2019 05:32PM

Add comment

Issue metadata