Feature Request: Validate Parameters to ActivityCompat.requestPermissions() [122163323]

Fixed

Bug

Status Update

No update yet.

Description

mm...@commonsware.com

created issue #1

Jan 1, 2019 12:54AM

Component used: androidx.core
Version used: 1.0.1
Devices/Android versions reproduced on: n/a

Right now, AFAICT, ActivityCompat.requestPermissions() performs no validation on the parameters. Ideally, it would at least check the String[] of permissions to confirm that the elements are sane (i.e., not null, not empty).

Otherwise, failures happen deep in the system. For example, if you pass null in one of the array elements, the eventual NullPointerException actually occurs in com.android.packageinstaller.permission.ui.GrantPermissionsActivity. See

https://stackoverflow.com/q/53992172/115145 for an example.

Thanks for considering this!

Comments

je...@google.com <je...@google.com> Apr 29, 2020 04:38PM

Assigned to au...@google.com.

au...@google.com <au...@google.com> May 4, 2020 05:42PM

Reassigned to il...@google.com.

il...@google.com <il...@google.com> May 8, 2020 06:25PM

Reassigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2May 11, 2020 04:48PM

Can someone please provide an example of Notification.BigPictureStyle().bigPicture(...) working with an animated image? From the description of this issue and the API 31 requirement, I am assuming an Icon must be passed to .bigPicture(). However, what configurations does the Icon need in order to animate?

I have scoured the internet, but am unable to find a single example of this even though Google boldly announced it in their overview of Android 12 features.

Edit: Also requested here

jb...@google.com <jb...@google.com> #3May 11, 2020 06:08PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a2b7f7b7268c8f24b6e3a66bf58017f39c329b68
Author: Alexander Roederer <aroederer@google.com>
Date: Thu Jun 16 17:45:43 2022

Adds support for BigPictureStyle using Icon

Modifies Notification.java to use Icon as the base representation
for BigPicture in BigPictureStyle. Also adds tests to ensure both
Icon and Bitmap representation are functional.

Bug: 215583339
Test: NotificationCompatTest integration tests added
Relnote: Adds support for BigPictureStyle using Icon
Change-Id: Ice26d1400836cdf74af931f0f8ca59c25dd9c3c3

M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/app/NotificationCompat.java
M core/core/api/public_plus_experimental_current.txt
M core/core/src/androidTest/java/androidx/core/app/NotificationCompatTest.java
M core/core/api/current.txt

https://android-review.googlesource.com/2129854

Issue 122163323