Feature Request: Validate Parameters to ActivityCompat.requestPermissions() [122163323]

Fixed

Bug

Status Update

No update yet.

Description

mm...@commonsware.com

created issue #1

Jan 1, 2019 12:54AM

Component used: androidx.core
Version used: 1.0.1
Devices/Android versions reproduced on: n/a

Right now, AFAICT, ActivityCompat.requestPermissions() performs no validation on the parameters. Ideally, it would at least check the String[] of permissions to confirm that the elements are sane (i.e., not null, not empty).

Otherwise, failures happen deep in the system. For example, if you pass null in one of the array elements, the eventual NullPointerException actually occurs in com.android.packageinstaller.permission.ui.GrantPermissionsActivity. See

https://stackoverflow.com/q/53992172/115145 for an example.

Thanks for considering this!

Comments

je...@google.com <je...@google.com> Apr 29, 2020 04:38PM

Assigned to au...@google.com.

au...@google.com <au...@google.com> May 4, 2020 05:42PM

Reassigned to il...@google.com.

il...@google.com <il...@google.com> May 8, 2020 06:25PM

Reassigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2May 11, 2020 04:48PM

The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.

jb...@google.com <jb...@google.com> #3May 11, 2020 06:08PM

Marked as fixed.

The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.

Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.

Issue 122163323