Feature Request: Validate Parameters to ActivityCompat.requestPermissions() [122163323]

Fixed

Bug

Status Update

No update yet.

Description

mm...@commonsware.com

created issue #1

Jan 1, 2019 12:54AM

Component used: androidx.core
Version used: 1.0.1
Devices/Android versions reproduced on: n/a

Right now, AFAICT, ActivityCompat.requestPermissions() performs no validation on the parameters. Ideally, it would at least check the String[] of permissions to confirm that the elements are sane (i.e., not null, not empty).

Otherwise, failures happen deep in the system. For example, if you pass null in one of the array elements, the eventual NullPointerException actually occurs in com.android.packageinstaller.permission.ui.GrantPermissionsActivity. See

https://stackoverflow.com/q/53992172/115145 for an example.

Thanks for considering this!

Comments

je...@google.com <je...@google.com> Apr 29, 2020 04:38PM

Assigned to au...@google.com.

au...@google.com <au...@google.com> May 4, 2020 05:42PM

Reassigned to il...@google.com.

il...@google.com <il...@google.com> May 8, 2020 06:25PM

Reassigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2May 11, 2020 04:48PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

jb...@google.com <jb...@google.com> #3May 11, 2020 06:08PM

Marked as fixed.

Thanks for the report!

Issue 122163323