IssueTracker

Agree

Also it causes slider to be unusable while onValuChangeFinished != null

#comment1 could you provide all of your dependencies for your project that you saw the issue in? It might have been fixed by a foundational module that Material3 depends on.

Ran into the same issue, the onValuChangeFinished lambda is being passed as a remember key so recreates the state if that lambda reference changes (as seen in https://issuetracker.google.com/issues/322269951#comment5). You can work around it by remembering the lambda itself.

val context = LocalContext.current
var sliderPosition by remember { mutableStateOf(0f) }
val onValueChangeFinished: () -> Unit = remember {
  { Toast.makeText(context, sliderPosition.toString(), Toast.LENGTH_SHORT).show() }
}
Text(text = sliderPosition.toString())

Slider(
    value = sliderPosition, 
    onValueChange = { sliderPosition = it }, 
    onValueChangeFinished = onValueChangeFinished
)

Feb 19 is a U.S. holiday, there are 12+ impacted so far, Kevin, could you please take a look on tues once you are back at work? ty!

Yup, taking a look. Thanks Connie!

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.material3:material3:1.2.1
• androidx.compose.material3:material3-android:1.2.1
• androidx.compose.material3:material3-desktop:1.2.1
• androidx.compose.material3:material3:1.3.0-alpha02
• androidx.compose.material3:material3-android:1.3.0-alpha02
• androidx.compose.material3:material3-desktop:1.3.0-alpha02

I don't think I've seen this mentioned yet, but another workaround is to use an AndroidView.

For example:

AndroidView(
    factory = { context ->
        TextView(context, null, R.style.Body).apply {
            text = "Some text"
            setLines(2)
        }
    }
)

Is that not the point? getting away from XML -> Compose?

I agree with #15. The goal is to be independent of XML layouts. Android Views may work for a while, but not in the long term.

I understand the need for a simpler API.

Is a line equal to lineHeight + fontSize, or max(lineHeight, fontSize), or something else?

• A line is lineHeight.toPx() * 1, x lines is lineHeight.toPx() * x
• if lineHeight is not defined, it is fontSize.toPx() * x

It is necessarily very accurate and might require an if.

This could be in the form of adding a minLines parameter to TextField

a new TextStyle method that returns the height of a line based on this TextStyle's font size and line height

Both are good suggestions. I would love to have a Modifier.minLines(X) or Modifier.minLines(X, textStyle) rather than parameters if it was possible.

It seen this project is just been sent from one desk stack to another desk stack, are you afraid to implement it?

Assigned for the open CL at aosp/2237754

The following release(s) address this bug:

• androidx.compose.foundation:foundation:1.4.0-alpha01

Are you certain this landed in 1.4.0-alpha01? I was not able to find this API in the new release. Android Studio doesn't show me a minLines: Int argument when I update to 1.4.0-alpha01.

Alex is right, the API change haven't landed in 1.4.0-alpha. We cut the build just before the API change in BasicText(Field) landed so the build only contains the implementation.

minLines is not used in the basicText implementation so it's not working :

line 212 of BasicText :

 val controller = remember {
        TextController(
            TextState(
                TextDelegate(
                    text = text,
                    style = style,
                    density = density,
                    softWrap = softWrap,
                    fontFamilyResolver = fontFamilyResolver,
                    overflow = overflow,
                    maxLines = maxLines,
                    placeholders = placeholders
                ),
                selectableId
            )
        )
    }

minLines = minLines is missing in the TextDelegate constructor

Edit: I'm on 1.4.0-alpha02

Good catch! We missed that during code review, on it.

Please note that String override should be fine, it wasn't propagated to AnnotatedString override only.

The reverted commit was rever-reverted via b/263371866 and https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2367789 by Halil.

This ticket should be fixed. Looks like there is something about the Density's that are being used on device that need some attention. They do not set the font scale therefore they are impacted by the font scale on the device.

Based onthe comment on the other ticket

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.foundation:foundation:1.4.0-alpha04