IssueTracker

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.graphics:graphics-shapes:1.0.0-alpha04

Hi

This should be doable with height/layout calculations with onTextLayoutResult, or even before by calculating the final px min height with the fontSize (and maybe lineHeight) that you provide.

Currently minimum lines and maximum lines are different in my perspective since maxLines is more closely related to text, where minLines is more about height calculations.

Since the issue is voted a lot of times, can you please elaborate the challenge and issue with setting the height based on fontSize?

How do you set the height based on fontSize? I am trying to set the height to 2 lines, so I converted the fontSize to DP then multiplied that by 2, however the resulting height fits only about 1 line. So what's the exact formula? And how does line height fit into it? Is a line equal to lineHeight + fontSize, or max(lineHeight, fontSize), or something else?

It would be beneficial if this calculation was available through the API so the developer does not have to figure out and perform the math manually. This could be in the form of adding a minLines parameter to TextField, or even a new TextStyle method that returns the height of a line based on this TextStyle's font size and line height. The latter solution would be more versatile and fits with your philosophy that minLines is more about height calculations and not necessarily the responsibility of the TextField as much as maxLines is.

One reason I can think of to offer a minLines property of TextField instead is that doesn't the TextField have some padding around the text? So if you set the height directly to how tall a line should be, then that wouldn't be accounting for the TextField padding, and the resulting height would not fit the padding in addition to the line height, so the line would be slightly cut off.

Yes Please, Giv attention

In response to #comment9 I think you can create a modifier to calculate a min height similar to how it is done for max lines: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/MaxLinesHeightModifier.kt;l=38;drc=69c21b55fb406c60eaf4ba4b722f4084e6716cec

But I agree that it would be better to have an API to make this automatic similar to EditText.

I have outlined a workaround here, but it requires one additional recomposition of the Text Composable.

Would be great to get official minLines support here as requirements like "The text needs to be exactly x lines long" (usually combined with ellipsize) is very common when receiving designs as a developer.

I don't think I've seen this mentioned yet, but another workaround is to use an AndroidView.

For example:

AndroidView(
    factory = { context ->
        TextView(context, null, R.style.Body).apply {
            text = "Some text"
            setLines(2)
        }
    }
)

Is that not the point? getting away from XML -> Compose?

I agree with #15. The goal is to be independent of XML layouts. Android Views may work for a while, but not in the long term.

I understand the need for a simpler API.

Is a line equal to lineHeight + fontSize, or max(lineHeight, fontSize), or something else?

• A line is lineHeight.toPx() * 1, x lines is lineHeight.toPx() * x
• if lineHeight is not defined, it is fontSize.toPx() * x

It is necessarily very accurate and might require an if.

This could be in the form of adding a minLines parameter to TextField

a new TextStyle method that returns the height of a line based on this TextStyle's font size and line height

Both are good suggestions. I would love to have a Modifier.minLines(X) or Modifier.minLines(X, textStyle) rather than parameters if it was possible.

It seen this project is just been sent from one desk stack to another desk stack, are you afraid to implement it?

Assigned for the open CL at aosp/2237754

The following release(s) address this bug:

• androidx.compose.foundation:foundation:1.4.0-alpha01

Are you certain this landed in 1.4.0-alpha01? I was not able to find this API in the new release. Android Studio doesn't show me a minLines: Int argument when I update to 1.4.0-alpha01.

Alex is right, the API change haven't landed in 1.4.0-alpha. We cut the build just before the API change in BasicText(Field) landed so the build only contains the implementation.

minLines is not used in the basicText implementation so it's not working :

line 212 of BasicText :

 val controller = remember {
        TextController(
            TextState(
                TextDelegate(
                    text = text,
                    style = style,
                    density = density,
                    softWrap = softWrap,
                    fontFamilyResolver = fontFamilyResolver,
                    overflow = overflow,
                    maxLines = maxLines,
                    placeholders = placeholders
                ),
                selectableId
            )
        )
    }

minLines = minLines is missing in the TextDelegate constructor

Edit: I'm on 1.4.0-alpha02

Good catch! We missed that during code review, on it.

Please note that String override should be fine, it wasn't propagated to AnnotatedString override only.

The reverted commit was rever-reverted via b/263371866 and https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2367789 by Halil.

This ticket should be fixed. Looks like there is something about the Density's that are being used on device that need some attention. They do not set the font scale therefore they are impacted by the font scale on the device.

Based onthe comment on the other ticket

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.foundation:foundation:1.4.0-alpha04