Change Propagation using BaseObservable not working after setLifecycleOwner [122553653]

Fixed

Bug

Status Update

No update yet.

Description

cy...@forcklabs.com

created issue #1

Jan 9, 2019 02:53PM

Steps to reproduce using the attached Example Project:
1. launch the project
2. the timer increments every second
3. use the 'launch B' button to start another activity
4. use the 'back' button to return to activity A
5. the timer updates upon returning and then stops

After removing `setLifecycleOwner` the app works as expected

For more information see:

https://github.com/googlesamples/android-architecture-components/issues/310

data_binding_bug.zip

131 KB

Download

Comments

da...@google.com <da...@google.com> #2Jan 9, 2019 05:54PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Anastasia Soboleva <soboleva@google.com>
Link: https://android-review.googlesource.com/3307383

Add internal APIs to add bullet list from the AnnotatedString builder

Expand for full commit details

Add internal APIs to add bullet list from the AnnotatedString builder 
 
When we're past API freeze, make this APIs public. 
 
Bug: 299662276, 139326648 
Test: AnnotatedStringBuilderTest 
Change-Id: I2212987ce813ff55cca3d2a4fa4aeb23dd86ec01

Files:

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/style/BulletSpan.android.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/AnnotatedStringBuilderTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/AnnotatedString.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Bullet.kt

Hash: eb01d1a28091a1c7c7d370a0000d0a077f6c0d0c
Date: Tue Oct 15 19:21:49 2024

yb...@google.com <yb...@google.com> #3Jan 10, 2019 12:43AM

Assigned to yb...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Anastasia Soboleva <soboleva@google.com>
Link: https://android-review.googlesource.com/3307382

Add ul/li tags support to fromHtml

Expand for full commit details

Add ul/li tags support to fromHtml 
 
Unlike TextView where indentation is added but bullet is always drawn at 0, in this implementation the bullet follows the start of text in the paragraph meaning that it's drawn with the indentation. 
 
Test: new tests and updated demo 
Bug: 299662276, 139326648 
Relnote: "AnnotatedString.fromHtml now supports <ul>/<li> tags" 
Change-Id: I7c2fe1717e72b66da4b2613efbeeb7b6f5ebb44e

Files:

M compose/ui/ui-text/samples/src/main/res/values/styled-string-for-sample.xml
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/AnnotatedStringFromHtmlTest.kt
M compose/ui/ui-text/src/androidInstrumentedTest/res/values/styled-string-for-test.xml
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/Html.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/style/BulletSpan.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/style/DrawStyleSpan.android.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/AnnotatedStringBuilderTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/AnnotatedString.kt
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Bullet.kt

Hash: b6d4b40b1a0ffe65c9869ddcde3f133534a10a89
Date: Tue Oct 15 14:30:50 2024

yb...@google.com <yb...@google.com> #4Jan 10, 2019 12:51AM

sadly it reproduces 3.4.0 alpha 10 as well :/.

looking into it.

yb...@google.com <yb...@google.com> #5Jan 10, 2019 01:10AM

looks like an issue in request rebind.

It avoids updating the UI when stopped but then forgets to trigger an update because flag is already set to true :/.

This works fine with LiveData since LiveData will not even send the update if lifecycle is stopped.

Pretty bad bug, again, thanks for the report. I'll work on a fix. Meanwhile, you dont' really need lifecycle for observables.

protected void requestRebind() {
if (mContainingBinding != null) {
mContainingBinding.requestRebind();
} else {
synchronized (this) {
if (mPendingRebind) {
return;
}
mPendingRebind = true;
}
if (mLifecycleOwner != null) {
Lifecycle.State state = mLifecycleOwner.getLifecycle().getCurrentState();
if (!state.isAtLeast(Lifecycle.State.STARTED)) {
return; // wait until lifecycle owner is started
}
}
if (USE_CHOREOGRAPHER) {
mChoreographer.postFrameCallback(mFrameCallback);
} else {
mUIThreadHandler.post(mRebindRunnable);
}
}
}

yb...@google.com <yb...@google.com> #6Jan 10, 2019 02:03AM

actually, to be more precise,
DataBinding does observe the lifecycle so nothing wrong in that code.
problem happens because when onStart event comes, it only rebinds but fails to clear rebind pending flag hence no other observable works afterwards (because flag is set and it assumes there is a pending rebind :/ )

yb...@google.com <yb...@google.com> #7Jan 11, 2019 02:25AM

Marked as fixed.

will be fixed in 3.4 beta2 and trying to cherry pick into the next 3.3 dot fix release.

yb...@google.com <yb...@google.com> #8Jan 14, 2019 11:59PM

also merged into the 3.3 branch. should be avilable in any foollowup 3.3 release, if that happens.