Fixed
Status Update
Comments
ad...@google.com <ad...@google.com> #2
Removing from wednesday's list for now since there have been no reports.
kc...@google.com <kc...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d02b8afc951f6a9e0fc8e24e19e56a06f1f60fac
Author: Curtis Belmonte <curtislb@google.com>
Date: Wed Sep 11 14:33:54 2019
Tolerate null result in BiometricPrompt fragments
The AndroidX BiometricPrompt API for onAuthenticationSucceeded requires
a non-null AuthenticationResult, so we construct one from the platform
BiometricPrompt or FingerprintManagerCompat result in BiometricFragment
and FingerprintHelperFragment, respectively, when calling this method.
However, the platform API does not guarantee that the result it provides
will be non-null, in which case the current implementation would crash.
This commit fixes the issue by creating an AuthenticationResult with
null crypto when handling a null result in either of these places. It
also adds unit tests to verify the new behavior.
Test: ./gradlew biometric:connectedAndroidTest
Fixes: 138862251
Change-Id: I540dd3b4ebdf100553b4fac609f3d928ec69ebfb
A biometric/src/androidTest/java/androidx/biometric/BiometricFragmentTest.java
A biometric/src/androidTest/java/androidx/biometric/FingerprintHelperFragmentTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
M biometric/src/main/java/androidx/biometric/FingerprintHelperFragment.java
https://android-review.googlesource.com/1122743
https://goto.google.com/android-sha1/d02b8afc951f6a9e0fc8e24e19e56a06f1f60fac
Branch: androidx-master-dev
commit d02b8afc951f6a9e0fc8e24e19e56a06f1f60fac
Author: Curtis Belmonte <curtislb@google.com>
Date: Wed Sep 11 14:33:54 2019
Tolerate null result in BiometricPrompt fragments
The AndroidX BiometricPrompt API for onAuthenticationSucceeded requires
a non-null AuthenticationResult, so we construct one from the platform
BiometricPrompt or FingerprintManagerCompat result in BiometricFragment
and FingerprintHelperFragment, respectively, when calling this method.
However, the platform API does not guarantee that the result it provides
will be non-null, in which case the current implementation would crash.
This commit fixes the issue by creating an AuthenticationResult with
null crypto when handling a null result in either of these places. It
also adds unit tests to verify the new behavior.
Test: ./gradlew biometric:connectedAndroidTest
Fixes: 138862251
Change-Id: I540dd3b4ebdf100553b4fac609f3d928ec69ebfb
A biometric/src/androidTest/java/androidx/biometric/BiometricFragmentTest.java
A biometric/src/androidTest/java/androidx/biometric/FingerprintHelperFragmentTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
M biometric/src/main/java/androidx/biometric/FingerprintHelperFragment.java
kc...@google.com <kc...@google.com>
kc...@google.com <kc...@google.com> #6
Let's not close the bug till treehugger submits the change
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 33d1f118bbd3b3f2c77cae306f5a495f445fa0f7
Author: joshmccloskey <joshmccloskey@google.com>
Date: Fri Jan 18 15:50:33 2019
BioFrag is now maintaining it's bundle state.
Fixes: 122856773
Test: Manual. Verified on O & P that an incremental counter applied to text fields
are reflected within the demo when starting/stopping BiometricPrompt.
Change-Id: Iaae2c612fed117c0cb4f7c0e3a94cc1aa6533358
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
M biometric/src/main/java/androidx/biometric/BiometricPrompt.java
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
M samples/BiometricDemos/src/main/java/com/example/android/biometric/BiometricPromptDemo.java
https://android-review.googlesource.com/878834
https://goto.google.com/android-sha1/33d1f118bbd3b3f2c77cae306f5a495f445fa0f7
Branch: androidx-master-dev
commit 33d1f118bbd3b3f2c77cae306f5a495f445fa0f7
Author: joshmccloskey <joshmccloskey@google.com>
Date: Fri Jan 18 15:50:33 2019
BioFrag is now maintaining it's bundle state.
Fixes: 122856773
Test: Manual. Verified on O & P that an incremental counter applied to text fields
are reflected within the demo when starting/stopping BiometricPrompt.
Change-Id: Iaae2c612fed117c0cb4f7c0e3a94cc1aa6533358
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
M biometric/src/main/java/androidx/biometric/BiometricPrompt.java
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
M samples/BiometricDemos/src/main/java/com/example/android/biometric/BiometricPromptDemo.java
ph...@gmail.com <ph...@gmail.com> #8
Run
ph...@gmail.com <ph...@gmail.com> #9
Run
ph...@gmail.com <ph...@gmail.com> #10
Run
Description
Version used: 1.0.0-alpha03
Theme used: Default
Devices/Android versions reproduced on:
Pixel 3, Android P, PQ1A.190105.004
Sony XZ, Oreo, 8.0.0
- Relevant code to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).