androidx.biometric. PromptInfo title/description not changed on Android P [122856773]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jan 15, 2019 10:15AM

Artifact used : androidx.biometric:biometric
Version used: 1.0.0-alpha03
Theme used: Default
Devices/Android versions reproduced on:

Pixel 3, Android P, PQ1A.190105.004
Sony XZ, Oreo, 8.0.0

- Relevant code to trigger the issue.

https://github.com/ksc91u/RxBiometric/tree/androidx-pr

- A screenrecord or screenshots showing the issue (if UI related).

https://drive.google.com/a/mith.io/file/d/1dLu26mZph22ms2qCEYOS1R0DW0Z2hRmr/view?usp=drive_web (IMG_1744.MOV)

Comments

ad...@google.com <ad...@google.com> #2Jan 15, 2019 11:00AM

Assigned to kc...@google.com.

Could you please provide the dependencies you're using for your project?

Compose does not use protos for any production use case, so we will need more information to determine which dependency is pulling in the protobuf dependency.

kc...@google.com <kc...@google.com> #3Jan 17, 2019 05:00AM

libs.versions.toml does have protobuf version as "3.19.4"

And protobufs are used in production code for app inspection jars like the layout inspector jar that comes with compose:ui:ui

kc...@google.com <kc...@google.com> Jan 18, 2019 07:46PM

Reassigned to jo...@google.com.

jo...@google.com <jo...@google.com> #4Jan 22, 2019 11:02PM

Marked as fixed.

Oh interesting, build.gradle doesn't declare this dependency though? Curious if androidx-main is the only place we'd to update.

jo...@google.com <jo...@google.com> #5Jan 22, 2019 11:04PM

Compose UI 1.3.2 updates this dependency: https://developer.android.com/jetpack/androidx/releases/compose-ui#1.3.2

kc...@google.com <kc...@google.com> #6Jan 25, 2019 12:46AM

Thanks

ap...@google.com <ap...@google.com> #7Jan 25, 2019 12:47AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 33d1f118bbd3b3f2c77cae306f5a495f445fa0f7
Author: joshmccloskey <joshmccloskey@google.com>
Date: Fri Jan 18 15:50:33 2019

BioFrag is now maintaining it's bundle state.

Fixes: 122856773

Test: Manual. Verified on O & P that an incremental counter applied to text fields
are reflected within the demo when starting/stopping BiometricPrompt.

Change-Id: Iaae2c612fed117c0cb4f7c0e3a94cc1aa6533358

M biometric/src/main/java/androidx/biometric/BiometricFragment.java
M biometric/src/main/java/androidx/biometric/BiometricPrompt.java
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
M samples/BiometricDemos/src/main/java/com/example/android/biometric/BiometricPromptDemo.java

https://android-review.googlesource.com/878834

https://goto.google.com/android-sha1/33d1f118bbd3b3f2c77cae306f5a495f445fa0f7

ph...@gmail.com <ph...@gmail.com> #8Apr 4, 2019 04:29PM

Run

ph...@gmail.com <ph...@gmail.com> #9Apr 4, 2019 05:17PM

Run

ph...@gmail.com <ph...@gmail.com> #10Apr 4, 2019 05:32PM

Run