Status Update
No update yet.
Comments
ve...@google.com
ve...@google.com
From
public synchronized void onResponseStarted(UrlRequest request, UrlResponseInfo info) {
if (request != currentUrlRequest) {
return;
}
responseInfo = info;
operation.open();
}
The HttpEngineNativeProvider
ja...@gmail.com
Automated by Blunderbuss job cronet_sheriff_blunderbuss_autoassigner for component 1456244.
ve...@google.com
kc...@google.com
From
on 15/03/2024: issue 324583507
Project: chromium/src
Branch: main
commit 7f7c0e994c2234cfe6c78aaed156bac633f95bc6
Author: Chidera Olibie
Date: Fri Mar 15 11:26:07 2024
[Cronet] Modify request/stream's equality check
While our documentation does not guarantee that the request/stream
passed to the callbacks will be the same as the one created by the
user, our users have assumed this is the case. Eg
compares the request objects in their callbacks.
This cl changes the equals method to, in addition to the original
equality check, consider two wrappers with same backend to be equal.
Bug:
Change-Id: I266228a802b89778ae5a91d9be3e0c6e32a584b1
Reviewed-on:
Reviewed-by: Etienne Dechamps
Reviewed-by: Stefano Duo
Commit-Queue: Chidera Olibie
Cr-Commit-Position: refs/heads/main@{#1273331}
M components/cronet/android/BUILD.gn
M components/cronet/android/java/src/org/chromium/net/impl/AndroidBidirectionalStreamBuilderWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidBidirectionalStreamCallbackWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidBidirectionalStreamWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidHttpEngineWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidUrlRequestBuilderWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidUrlRequestCallbackWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidUrlRequestWrapper.java
M components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
M components/cronet/android/test/javatests/src/org/chromium/net/CronetTestRule.java
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
M components/cronet/android/test/javatests/src/org/chromium/net/TestBidirectionalStreamCallback.java
M components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java
A components/cronet/android/test/javatests/src/org/chromium/net/impl/AndroidBidirectionalStreamWrapperTest.java
A components/cronet/android/test/javatests/src/org/chromium/net/impl/AndroidUrlRequestWrapperTest.java
jo...@google.com
From
on 15/03/2024: issue 324583507
fyi: This last paragraph of the cl description above is incorrect.
Correct:
This cl changes the callback wrappers to use the same request/stream object as the one created during build.
ap...@google.com
Automated by Blunderbuss job cronet_sheriff_blunderbuss_autoassigner for component 1456244.
Description
Artifact used
Version used: androidx.biometric:biometric:1.0.0-alpha03
Devices/Android versions reproduced on:
Samsung SM-G965F / Android 9
Samsung SM-G960F / Android 9
Samsung SM-N960F / Android 9
- Relevant code to trigger the issue.
```
override fun onAuthenticationError(errorCode: Int, errString: CharSequence) {
// ... my code
}
```
bytecode generated:
```
public onAuthenticationError(ILjava/lang/CharSequence;)V
@Lorg/jetbrains/annotations/NotNull;() // invisible, parameter 1
L0
ALOAD 2
LDC "errString"
INVOKESTATIC kotlin/jvm/internal/Intrinsics.checkParameterIsNotNull (Ljava/lang/Object;Ljava/lang/String;)V
// .. my code
```
cause exception:
```
Fatal Exception: java.lang.IllegalArgumentException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter errString
at com.example$callback$1.onAuthenticationError(Unknown Source:3)
at androidx.biometric.BiometricFragment$2$1.run(BiometricFragment.java:82)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:6981)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1445)
```